Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor has been renamed to contributor #7129

Closed
tcoupin opened this issue Jul 24, 2020 · 6 comments · Fixed by #9012
Closed

Editor has been renamed to contributor #7129

tcoupin opened this issue Jul 24, 2020 · 6 comments · Fixed by #9012
Milestone

Comments

@tcoupin
Copy link
Member

tcoupin commented Jul 24, 2020

See #6662

@djbrooke
Copy link
Contributor

Hi @tcoupin, can you please tell us more about the issue here?

@tcoupin
Copy link
Member Author

tcoupin commented Jul 28, 2020

BuiltInroles must be updated: role.editor.name become role.contributor.name

It's not important for english since if the key is not founds, name and description from https://github.com/IQSS/dataverse/blob/941d17dd0c196f8443a9512db40e4be002cbe572/scripts/api/data/role-editor.json is used (in english too...)

But it is important for other language

@pdurbin
Copy link
Member

pdurbin commented Jul 28, 2020

I see. You want to make the following change...

$ git diff src/main/java/propertyFiles/BuiltInRoles.properties
diff --git a/src/main/java/propertyFiles/BuiltInRoles.properties b/src/main/java/propertyFiles/BuiltInRoles.properties
index 3c4b80200..115ccf6af 100644
--- a/src/main/java/propertyFiles/BuiltInRoles.properties
+++ b/src/main/java/propertyFiles/BuiltInRoles.properties
@@ -1,7 +1,7 @@
 role.admin.name=Admin
 role.admin.description=A person who has all permissions for dataverses, datasets, and files.
-role.editor.name=Contributor
-role.editor.description=For datasets, a person who can edit License + Terms, and then submit them for review.
+role.contributor.name=Contributor
+role.contributor.description=For datasets, a person who can edit License + Terms, and then submit them for review.
 role.curator.name=Curator
 role.curator.description=For datasets, a person who can edit License + Terms, edit Permissions, and publish datasets.
 role.dscontributor.name=Dataset Creator

... and then update BuiltInRoles.properties in the language packs to use the new keys? I see you opened GlobalDataverseCommunityConsortium/dataverse-language-packs#76

Thanks for the tip that this doesn't affect English installations.

In a French installation, does it fall back to English? Or do you get an error?

@pdurbin
Copy link
Member

pdurbin commented Oct 1, 2022

@tcoupin hi! Are you thinking about making a pull request for this?

@tcoupin
Copy link
Member Author

tcoupin commented Oct 3, 2022

On my v5.10 stagging server with branch 5.10
image

I will open a new PR on https://github.com/GlobalDataverseCommunityConsortium /
dataverse-language-packs

@tcoupin
Copy link
Member Author

tcoupin commented Oct 3, 2022

2 PR opened on https://github.com/GlobalDataverseCommunityConsortium/dataverse-language-packs
1 PR on dataverse

pdurbin added a commit to tcoupin/dataverse that referenced this issue Apr 10, 2023
@pdurbin pdurbin added this to the 5.14 milestone May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants