-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: deprecate toggle of superuser status in favor of new idempotent endpoint, update setup-all.sh #10440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks! Please see my comments.
Huh. Please hit me up in https://chat.dataverse.org and I can try to help. I'll point you toward running Dataverse in Docker: https://preview.guides.gdcc.io/en/develop/developers/dev-environment.html#quickstart Anyway, I know you can't see the results of Jenkins testing this pull request... ... but here's a screenshot from https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10440/1/testReport/edu.harvard.iq.dataverse.api/AdminIT/ that shows your tests (all tests, really) are passing: ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A comment on deprecation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is really coming together! Thanks, @zearaujo25 !
I left some more feedback for you.
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little more feedback.
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question about curl.
Also, I merged develop into this branch.
@zearaujo25 and I chatted and we decided on the following:
|
I also would like to add the supersuer feature for the SPA probably will need a restructure of endpoints logic. Since its too early to predict such changes, we opt to defer this feature when its clearer the needs the front end team will need |
Yes, exactly. I did ping @ekraffmiller @GPortas @MellyGray and @GermanSaracca about this in Slack: https://iqss.slack.com/archives/C04MJ76A34Z/p1712942297281699 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zearaujo25 this is looking really good. Approved! Thank you!
To whoever does QA, I did a fair amount of testing and poking around. Please at least check that tests are passing and that the docs look ok.
What this PR does / why we need it:
Adds a new endpoint to make the superuser status change idempotent.
Which issue(s) this PR closes:
Special notes for your reviewer:
none
Suggestions on how to test this:
Integration test
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
New endpoint addition
Additional documentation:
Preview at https://dataverse-guide--10440.org.readthedocs.build/en/10440/api/native-api.html#set-superuser-status