Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Handling creation of duplicate role for a dataset object #10465

Closed
wants to merge 8 commits into from

Conversation

zearaujo25
Copy link
Contributor

@zearaujo25 zearaujo25 commented Apr 4, 2024

What this PR does / why we need it:
Handles the error properly when trying to create a role already existing for a particular dataset

Which issue(s) this PR closes:

Closes #9729

Special notes for your reviewer:

Suggestions on how to test this:
Integrations tests

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
no
Is there a release notes update needed for this change?:
no
Additional documentation:
no

@zearaujo25 zearaujo25 marked this pull request as ready for review April 4, 2024 18:25
@zearaujo25 zearaujo25 changed the title 9729: Handling creation of duplicate role for a dataset objects 9729: Handling creation of duplicate role for a dataset object Apr 4, 2024
@zearaujo25 zearaujo25 changed the title 9729: Handling creation of duplicate role for a dataset object API: Handling creation of duplicate role for a dataset object Apr 4, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the PR! I left some feedback.

@pdurbin pdurbin added Type: Bug a defect Feature: Permissions Size: 3 A percentage of a sprint. 2.1 hours. labels Apr 9, 2024
Co-authored-by: Philip Durbin <philipdurbin@gmail.com>
@zearaujo25
Copy link
Contributor Author

Closing this pr due rebasing issues

@zearaujo25 zearaujo25 closed this Apr 9, 2024
@zearaujo25 zearaujo25 deleted the fix/9729 branch April 9, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Permissions Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assigning role twice via API causes server error 500
3 participants