Skip to content

Solr 9.8.0 and other lib updates from QDR #10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 21, 2024

What this PR does / why we need it: QDR has updated to Solr 9.8.0 and uses other libraries that are more recent than the community version. This PR shows what QDR has changed.

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:
Note that as of Solr 9.8.0, I was seeing the error Search Syntax Error: Error from server at http://localhost:8983/solr/collection1: can not sort on a field w/o docValues unless it is indexed=true uninvertible=true and the type supports Uninversion: nameSort]] with the old definition using alphaOnlySort. The change to string seems to address the error and seems like a reasonable change to me - alphaOnlySort has an attribute regarding how to sort empty vals which isn't there on string, but I don't think we ever have empty names.

Heads up for Harvard/large sites: The 9.7.0 release notes include that Apache Lucene upgraded to 9.11.1 introducing tremendous performance improvements when using Java 21 for vector search among other things. This PR doesn't change the Java version of anything, but it might be worth trying Solr with Java 21 for performance at Harvard/other large sites.

Suggestions on how to test this: Generally test indexing, regression, test the solr install docs, test that the Circuit breaker works at Harvard (@landreev might be able to help here)

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included
Additional documentation:

@qqmyers qqmyers added the Size: 3 A percentage of a sprint. 2.1 hours. label Jul 21, 2024
@coveralls
Copy link

coveralls commented Sep 3, 2024

Coverage Status

coverage: 22.721% (-0.005%) from 22.726%
when pulling c24b224 on QualitativeDataRepository:QDR-solr_and_libs_updates
into b0d136c on IQSS:develop.

pdurbin
pdurbin previously requested changes Oct 9, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is not complete. When we upgrade Solr we updated docs, Docker files, etc. Please see #10636 for example.

@pdurbin pdurbin added the Type: Feature a feature request label Oct 9, 2024
@qqmyers
Copy link
Member Author

qqmyers commented Oct 10, 2024

Thankfully many few places to change now that the files go in /conf/solr! As of now, the only 9.4.1 references are in the old release notes.

@qqmyers qqmyers removed their assignment Oct 10, 2024
@pdurbin
Copy link
Member

pdurbin commented Nov 7, 2024

Solr is such a moving target. 9.7 is out. Do we care? Stick with 9.6.1? https://solr.apache.org/downloads.html

p.s. There are merge conflicts.

@pdurbin
Copy link
Member

pdurbin commented Dec 4, 2024

Again, Solr is such a moving target. 9.7 is out. Do we care? Stick with 9.6.1? https://solr.apache.org/downloads.html

p.s. There are merge conflicts.

@qqmyers qqmyers changed the title Solr 9.6.1 and other lib updates from QDR Solr 9.7.0 and other lib updates from QDR Dec 12, 2024
@qqmyers
Copy link
Member Author

qqmyers commented Dec 18, 2024

FYI - @donsizemore ran this with solr 9.7.0 to show the tests pass - in https://jenkins.dataverse.org/job/IQSS-Dataverse-Solr_9.7.0/4/console.
Since the solrconfig.xml appears to not be compatible with solr 9.4.1, it looks like we need to update the normal build once this is merged to get the IT tests to work on develop.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just clearing "request changes" now that we're trying with the latest Solr (9.7).

@pdurbin pdurbin dismissed their stale review December 18, 2024 15:57

The latest Solr is used (9.7).

@qqmyers qqmyers mentioned this pull request Dec 20, 2024
@cmbz cmbz added the FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) label Jan 30, 2025
@qqmyers qqmyers changed the title Solr 9.7.0 and other lib updates from QDR Solr 9.8.0 and other lib updates from QDR Jan 30, 2025
@qqmyers
Copy link
Member Author

qqmyers commented Feb 7, 2025

I'm guessing the test fails are because we need to build against solr 9.8.0. The solrconfig.xml used here works fine for me to spin up 9.8.0 on a QDR test machine.

@donsizemore
Copy link
Contributor

the Jenkins job failed (no permission to update the build status in QDR's GitHub repo) but all tests passed: https://jenkins.dataverse.org/job/IQSS-Dataverse-Solr_9.8.0/66/testReport/

@qqmyers qqmyers added this to the 6.6 milestone Feb 12, 2025
@cmbz cmbz added the FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) label Feb 12, 2025
@sekmiller
Copy link
Contributor

This is still failing a bunch of tests as of the latest merge from develop

@@ -5,7 +5,7 @@
# chkconfig: 35 92 08
# description: Starts and stops Apache Solr

SOLR_DIR="/usr/local/solr/solr-9.4.1"
SOLR_DIR="/usr/local/solr/solr-9.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 9.8.0 here


For the upgrade instructions section:

[note that 6.5 may contain other solr-related changes, so the instructions may need to contain information merged from multiple release notes!]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now 6.6, though the version number won't be part of the release note in this context

Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some failing tests and should probably get the latest from dev

@sekmiller sekmiller self-assigned this Feb 26, 2025
@sekmiller sekmiller moved this from Ready for Review ⏩ to In Review 🔎 in IQSS Dataverse Project Feb 26, 2025
@qqmyers
Copy link
Member Author

qqmyers commented Feb 26, 2025

Changes made. The tests fail because Jenkins is building against solr <9.8.0 . Don made a special run to show the tests pass against the right solr version - #10713 (comment)

@github-project-automation github-project-automation bot moved this from In Review 🔎 to Ready for QA ⏩ in IQSS Dataverse Project Feb 26, 2025
@sekmiller sekmiller removed their assignment Feb 26, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Feb 26, 2025
@ofahimIQSS ofahimIQSS self-assigned this Feb 26, 2025
@ofahimIQSS
Copy link
Contributor

continuous-integration/jenkins/pr-merge is failing - please advise. Thanks!

@sekmiller
Copy link
Contributor

@ofahimIQSS, as Jim notes above the tests are failing because Jenkins is on the prior version of Solr. When Don updated the version for a special run they passed.

@ofahimIQSS
Copy link
Contributor

regression testing passed - merging PR

@ofahimIQSS ofahimIQSS merged commit c235c2a into IQSS:develop Feb 26, 2025
13 of 14 checks passed
@github-project-automation github-project-automation bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Feb 26, 2025
@ofahimIQSS ofahimIQSS removed their assignment Feb 26, 2025
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) Size: 3 A percentage of a sprint. 2.1 hours. Type: Feature a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants