-
Notifications
You must be signed in to change notification settings - Fork 518
Solr 9.8.0 and other lib updates from QDR #10713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solr 9.8.0 and other lib updates from QDR #10713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is not complete. When we upgrade Solr we updated docs, Docker files, etc. Please see #10636 for example.
Thankfully many few places to change now that the files go in /conf/solr! As of now, the only 9.4.1 references are in the old release notes. |
Solr is such a moving target. 9.7 is out. Do we care? Stick with 9.6.1? https://solr.apache.org/downloads.html p.s. There are merge conflicts. |
Again, Solr is such a moving target. 9.7 is out. Do we care? Stick with 9.6.1? https://solr.apache.org/downloads.html p.s. There are merge conflicts. |
QDR-solr_and_libs_updates
https://github.com/QualitativeDataRepository/dataverse.git into QDR-solr_and_libs_updates
FYI - @donsizemore ran this with solr 9.7.0 to show the tests pass - in https://jenkins.dataverse.org/job/IQSS-Dataverse-Solr_9.7.0/4/console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just clearing "request changes" now that we're trying with the latest Solr (9.7).
I'm guessing the test fails are because we need to build against solr 9.8.0. The solrconfig.xml used here works fine for me to spin up 9.8.0 on a QDR test machine. |
the Jenkins job failed (no permission to update the build status in QDR's GitHub repo) but all tests passed: https://jenkins.dataverse.org/job/IQSS-Dataverse-Solr_9.8.0/66/testReport/ |
This is still failing a bunch of tests as of the latest merge from develop |
@@ -5,7 +5,7 @@ | |||
# chkconfig: 35 92 08 | |||
# description: Starts and stops Apache Solr | |||
|
|||
SOLR_DIR="/usr/local/solr/solr-9.4.1" | |||
SOLR_DIR="/usr/local/solr/solr-9.7.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be 9.8.0 here
|
||
For the upgrade instructions section: | ||
|
||
[note that 6.5 may contain other solr-related changes, so the instructions may need to contain information merged from multiple release notes!] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now 6.6, though the version number won't be part of the release note in this context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some failing tests and should probably get the latest from dev
Changes made. The tests fail because Jenkins is building against solr <9.8.0 . Don made a special run to show the tests pass against the right solr version - #10713 (comment) |
continuous-integration/jenkins/pr-merge is failing - please advise. Thanks! |
@ofahimIQSS, as Jim notes above the tests are failing because Jenkins is on the prior version of Solr. When Don updated the version for a special run they passed. |
regression testing passed - merging PR |
What this PR does / why we need it: QDR has updated to Solr 9.8.0 and uses other libraries that are more recent than the community version. This PR shows what QDR has changed.
Which issue(s) this PR closes:
Closes #
Special notes for your reviewer:
Note that as of Solr 9.8.0, I was seeing the error
Search Syntax Error: Error from server at http://localhost:8983/solr/collection1: can not sort on a field w/o docValues unless it is indexed=true uninvertible=true and the type supports Uninversion: nameSort]]
with the old definition usingalphaOnlySort
. The change tostring
seems to address the error and seems like a reasonable change to me - alphaOnlySort has an attribute regarding how to sort empty vals which isn't there on string, but I don't think we ever have empty names.Heads up for Harvard/large sites: The 9.7.0 release notes include that
Apache Lucene upgraded to 9.11.1 introducing tremendous performance improvements when using Java 21 for vector search among other things.
This PR doesn't change the Java version of anything, but it might be worth trying Solr with Java 21 for performance at Harvard/other large sites.Suggestions on how to test this: Generally test indexing, regression, test the solr install docs, test that the Circuit breaker works at Harvard (@landreev might be able to help here)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: