allow links between dataset types and metadata blocks #11001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
I just moved this back to in progress to work on JPA criteria queries. @pdurbin |
GPortas
reviewed
Nov 5, 2024
...ava/edu/harvard/iq/dataverse/engine/command/impl/UpdateDatasetTypeLinksToMetadataBlocks.java
Outdated
Show resolved
Hide resolved
GPortas
reviewed
Nov 5, 2024
src/main/java/edu/harvard/iq/dataverse/util/json/JsonPrinter.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
pdurbin
added
Type: Feature
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
stevenwinship
approved these changes
Jan 23, 2025
This comment has been minimized.
This comment has been minimized.
In Docker, we were testing with the Codemeta block. This made for a nice real-world story of creating a "software" dataset type and using it with the Codemeta block. The Codemeta block also has the advantage of having some fields that are set to displayOnCreate, which helped us make assertions that the code is working properly. It's the only non-citation block with fields set to displayOnCreate. However, Jenkins doesn't have the Codemeta block, meaning that tests are failing. Also, we aren't ready to promote the Codemeta block to be shipped with Dataverse because a new version is out: #10859 So, we are switching from Codemeta to the Astrophysics block. We create an "instrument" dataset type. Like all non-citation blocks (except for Codemeta), there are no fields that are set to displayOnCreate=true. Therefore, we added an API for this.
|
Tests were failing. Long story. I wrote it up in a commit message: 9b2fb8d @stevenwinship or others, please take a look. Thanks. |
This comment has been minimized.
This comment has been minimized.
|
This PR has merge conflicts - please resolve |
Conflicts: src/test/java/edu/harvard/iq/dataverse/api/UtilIT.java
|
@ofahimIQSS resolved! |
This comment has been minimized.
This comment has been minimized.
ofahimIQSS
reviewed
Feb 5, 2025
ofahimIQSS
reviewed
Feb 5, 2025
ofahimIQSS
reviewed
Feb 5, 2025
Co-authored-by: Omer Fahim <mfahim11427@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
Tested in internal - followed the updates on guides (also proofread), no issues found. Merging PR |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request builds on the first pull request for dataset types, bringing us closer to the proposal in the parent issue.
For the APIs used by the new Dataverse UI ( https://github.com/IQSS/dataverse-frontend ):
Which issue(s) this PR closes:
Special notes for your reviewer:
I haven't had a chance to look at the Criteria API yet. I could probably use some help getting up to speed.@GPortas helped me with this.What should we do about the tests in MetadataBlocksIT that fail if you add additional metadata blocks?In the end, I used existing metadata blocks.Suggestions on how to test this:
Try the documented APIs.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No, but the idea is that some day the SPA might show the ability to choose between types when creating a dataset (as discussed in Slack and IQSS/dataverse-client-javascript#210), like these examples:
Is there a release notes update needed for this change?:
Yes, included.
Additional documentation:
Included. See these pages: