sql script/flyway to fix file access requests #11061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenwinship
added
FY25 Sprint 11
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
sekmiller
reviewed
Dec 16, 2024
| AND far2.authenticated_user_id = fileaccessrequests.authenticated_user_id | ||
| AND far2.request_state is NULL); | ||
|
|
||
| UPDATE fileaccessrequests SET request_state='CREATED' WHERE request_state is NULL; |
There was a problem hiding this comment.
Did you consider putting a DB constraint on as Jim suggested?
There was a problem hiding this comment.
@qqmyers Could you add your suggestion here please?
Never mind. I see it in the Issue
sekmiller
approved these changes
Dec 16, 2024
This comment has been minimized.
This comment has been minimized.
|
Before PR in local After PR in local Merging PR no issues found |
ofahimIQSS
deleted the
10714-access-requests-missing-since-upgrade-v6-0
branch
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: To prevent duplicate keys when user requests access to a file
Which issue(s) this PR closes: #10714
Special notes for your reviewer:
Suggestions on how to test this: Delete docker-dev-volumes directory.
Check out develop branch first, build and deploy in docker.
Add dataset with multiple files (restricted) and publish the dataset.
From another user request access multiple times for multiple files.
Manually delete the "Created" from the request_state UPDATE fileaccessrequests SET request_state=NULL;
Checkout this PR, build and deploy.
You should see any duplicate requests deleted from the database (oldest will remain for each file/user). Once updated the database will have only one request for each file/user and the UI will show "Access Requested"
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: Included
Additional documentation: