Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11159 Add more information about anonymous access Preview URL; Limit Anon Access to Draft Versions #11164

Merged
merged 25 commits into from
Feb 3, 2025

Conversation

sekmiller
Copy link
Contributor

@sekmiller sekmiller commented Jan 16, 2025

What this PR does / why we need it:
In reviewing the complete list of dataset fields to be withheld from users of the anonymized Preview URL, the curation team suggested that the dataset depositor should have more info available - in particular the names of the metadata fields which will be withheld from the url user and suggestions on how they could test the preview url to make sure that the available Metadata does not reveal the identity of the depositor,

Which issue(s) this PR closes:

Special notes for your reviewer: no functional changes just tool tips and docs as suggested by curation team

Suggestions on how to test this: as a dataset owner in an installation that supports anonymous preview url make sure that the list of withheld metadata fields in the tool tip on the Preview URL popup matches the fields from the setting AnonymizedFieldTypeNames. Also review the proposed document changes.

With respect to 11202 - once you've looked at a dataset via a preview URL with anonymized access navigate over to a published dataset and verify that none of the metadata is "withheld".

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Screen Shot 2025-01-16 at 10 34 06 AM

Is there a release notes update needed for this change?: included

Additional documentation: the note on testing was added to the doc

@sekmiller sekmiller added the Size: 3 A percentage of a sprint. 2.1 hours. label Jan 16, 2025
@sekmiller sekmiller added this to the 6.6 milestone Jan 16, 2025
@sekmiller sekmiller added the FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) label Jan 16, 2025
@coveralls
Copy link

coveralls commented Jan 16, 2025

Coverage Status

coverage: 22.749% (-0.003%) from 22.752%
when pulling 1685a83 on 11159-anon-access-doc
into d8480ff on develop.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but the code looks reasonable. I'm leaving a little feedback.

doc/release-notes/11159-preview-url-update.md Outdated Show resolved Hide resolved
@@ -694,6 +694,9 @@ Creating a Preview URL for your dataset allows you to share your dataset (for vi
#. Copy the Preview URL which has been created for this dataset and it can now be shared with anyone you wish to have access to view or download files in your unpublished dataset.

To disable a Preview URL and to revoke access, follow the same steps as above until step #3 when you return to the popup, click the “Disable Preview URL” button.

Before distributing an anonymized Preview URL it is recommended that you view the dataset as a potential user to verify that the metadata available does not reveal authorship, etc. You must first log out of Dataverse then open the dataset via the anonymized Preview URL you plan to distribute. By logging out first, you will be able to view the dataset as it would be seen by the anonymized Preview URL user. It may be necessary for you to further edit your dataset's metadata to remove identifying items before you distribute the anonymized Preview URL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Before distributing an anonymized Preview URL it is recommended that you view the dataset as a potential user to verify that the metadata available does not reveal authorship, etc. You must first log out of Dataverse then open the dataset via the anonymized Preview URL you plan to distribute. By logging out first, you will be able to view the dataset as it would be seen by the anonymized Preview URL user. It may be necessary for you to further edit your dataset's metadata to remove identifying items before you distribute the anonymized Preview URL.
Before distributing an anonymized Preview URL it is recommended that you view the dataset as a potential user to verify that the metadata available does not reveal authorship, etc. You must first log out of Dataverse and then open the dataset via the anonymized Preview URL you plan to distribute. By logging out first, you will be able to view the dataset as it would be seen by the anonymized Preview URL user. It may be necessary for you to further edit your dataset's metadata to remove identifying items before you distribute the anonymized Preview URL.

I'm suggesting the same change below in the bundle but maybe we can discuss it here. I'm simply adding "and" but perhaps the whole paragraph could be made a bit shorter somehow? In the docs it's fine but in the tooltip (thanks for the screenshot!) it looks a bit big.

404042237-0be43c5d-9662-4daa-8c82-cf82e2d3cf94

I assume we're using a tooltip because we already have a lot of text in the popup and we're trying not to overwhelm the user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. And that's what Katie suggested and approved

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely take the point of having a lot of info in the tool tip here too. I just think there should be someplace where a user can access the list of fields that are anonymized. A link to somewhere in the guide would be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I removed the tool tip and replaced it with an update to the popup that includes a link to the documentation that includes detailed steps on how to view an anonymous url as a reviewer would see it

dataset.privateurl.anonymous.description.paragraph.two=The dataset's files are not changed and users of the Anonymous Preview URL will be able to access them. Users of the Anonymous Preview URL will not be able to see the name of the Dataverse that this dataset is in but will be able to see the name of the repository, which might expose the dataset authors' identities.
dataset.privateurl.anonymous.tooltip.testing=Before distributing an anonymized Preview URL it is recommended that you view the dataset as a potential user to verify that the metadata available does not reveal authorship, etc. You must first log out of Dataverse then open the dataset via the anonymized Preview URL you plan to distribute. By logging out first, you will be able to view the dataset as it would be seen by the anonymized Preview URL user. It may be necessary for you to further edit your dataset's metadata to remove identifying items before you distribute the anonymized Preview URL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dataset.privateurl.anonymous.tooltip.testing=Before distributing an anonymized Preview URL it is recommended that you view the dataset as a potential user to verify that the metadata available does not reveal authorship, etc. You must first log out of Dataverse then open the dataset via the anonymized Preview URL you plan to distribute. By logging out first, you will be able to view the dataset as it would be seen by the anonymized Preview URL user. It may be necessary for you to further edit your dataset's metadata to remove identifying items before you distribute the anonymized Preview URL.
dataset.privateurl.anonymous.tooltip.testing=Before distributing an anonymized Preview URL it is recommended that you view the dataset as a potential user to verify that the metadata available does not reveal authorship, etc. You must first log out of Dataverse and then open the dataset via the anonymized Preview URL you plan to distribute. By logging out first, you will be able to view the dataset as it would be seen by the anonymized Preview URL user. It may be necessary for you to further edit your dataset's metadata to remove identifying items before you distribute the anonymized Preview URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me think about making this shorter, but Katie is very concerned about someone distributing an anonymized preview that might contain identifying info.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before distributing an anonymized Preview URL it is recommended that you view the dataset as a potential user to verify that the metadata available does not reveal authorship, etc. You must first log out of Dataverse then open the dataset via the anonymized Preview URL you plan to distribute. By logging out first, you will be able to view the dataset as it would be seen by the anonymized Preview URL user. It may be necessary for you to further edit your dataset's metadata to remove identifying items before you distribute the anonymized Preview URL.

@pdurbin Just to be clear, in these instructions, we are assuming the user publishes the dataset and then goes back in and looks at it from a user perspective. Reading this, it may be unclear to the user whether they need to publish first and get a copy of the link before logging out. I know, hate being so specific but... This also implies if they want to review it, they are publishing a minor version with any additional anonymization they may need to do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about something like: "To verify that all identifying information has been removed or anonymized, it is recommended that you logout and review the dataset as as it would be seen by an anonymized Preview URL user." I think it could be fine to assume that a user understands the concept of "logging out to review" without having to explicitly talk them through each step and the reasoning behind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to take another pass at this. what I was trying to get across is that the author/depositor should view the dataset via the anonymous url before distributing it. That way they can see what the anonymous reviewer would see and be alerted to any metadata that may reveal authorship, etc.

Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@cmbz cmbz added the FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) label Jan 30, 2025

This comment has been minimized.

1 similar comment

This comment has been minimized.

@sekmiller
Copy link
Contributor Author

Made some more updates here based on further feedback from. Katie and Sonia. Additionally Sonia requested some redundancy in. the popup and User Guide to emphasize that the dataset must be unpublished and in draft.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@sekmiller sekmiller changed the title 11159 Add more information about anonymous access Preview URL 11159 Add more information about anonymous access Preview URL; Limit Anon Access to Draft Versions Jan 31, 2025
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is nicer, linking to the guides and having less text in the UI.

Also, I'm glad we're including a fix for #11202.

I haven't done any testing but I think this is looking good. Approved.

Oh, I did leave one comment below. I might be simply mis-remembering how Preview URL work. 😅

@@ -683,17 +683,26 @@ If you have a Contributor role (can edit metadata, upload files, and edit files,
Preview URL to Review Unpublished Dataset
=========================================

Creating a Preview URL for your dataset allows you to share your dataset (for viewing and downloading of files) before it is published to a wide group of individuals who may not have a user account on the Dataverse installation. Anyone you send the Preview URL to will not have to log into the Dataverse installation to view the dataset.
Creating a Preview URL for a draft version your dataset allows you to share your dataset (for viewing and downloading of files) before it is published to a wide group of individuals who may not have a user account on the Dataverse installation. Anyone you send the Preview URL to will not have to log into the Dataverse installation to view the unpublished dataset. Once a dataset has been published you may continue to use the General Preview URL for future drafts, but the Anonymous Preview URL will no longer be available.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I seem to remember that Preview URLs were deleted on publish but apparently that isn't the case anymore, if it ever was!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe unclear. Trying to say that you can make a new ":general" preview url for subsequent drafts. Didn't mean to say that the prior one would continue to work. I'll re-word it.

This comment has been minimized.

@ofahimIQSS ofahimIQSS self-assigned this Jan 31, 2025
@ofahimIQSS
Copy link
Contributor

code looks good, just made some documentation change suggestions. Will merge after doc changes have been reviewed/committed.

image

sekmiller and others added 2 commits February 3, 2025 09:45
Co-authored-by: Omer Fahim <mfahim11427@gmail.com>
Co-authored-by: Omer Fahim <mfahim11427@gmail.com>
@sekmiller
Copy link
Contributor Author

thanks for the review. I completed the suggested changes.

This comment has been minimized.

1 similar comment
Copy link

github-actions bot commented Feb 3, 2025

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11159-anon-access-doc
ghcr.io/gdcc/configbaker:11159-anon-access-doc

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@ofahimIQSS
Copy link
Contributor

merging PR

@ofahimIQSS ofahimIQSS merged commit 2df1f4b into develop Feb 3, 2025
13 of 14 checks passed
@ofahimIQSS ofahimIQSS deleted the 11159-anon-access-doc branch February 3, 2025 15:32
@ofahimIQSS ofahimIQSS removed their assignment Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 15 FY25 Sprint 15 (2025-01-15 - 2025-01-29) FY25 Sprint 16 FY25 Sprint 16 (2025-01-29 - 2025-02-12) Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: Done 🧹
7 participants