Session 2 Editorial #105
Open
Session 2 Editorial #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| t.string :name | ||
| t.string :roll_number | ||
| t.string :branch | ||
| t.decimal :cgpa, precision: 4, scale: 2 |
There was a problem hiding this comment.
Precision - Number of digits.
Scale - Number of digits after the decimal point.
Since CGPA has two digits after the decimal point and lies between 0 and 10, it will have scale of 2 and precison of 4.
But precision of 4 implies that 12.34 is valid CGPA, after it has 4 digits (precision) and 2 digits after decimal (scale).
Therefore, I have added a validation in app/models/student.rb to limit CGPA between 0 and 10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second session was more straightforward than the first two, as it built directly upon the concepts explained.