Skip to content

Commit

Permalink
fix: be more strict when checking ncs versions
Browse files Browse the repository at this point in the history
  • Loading branch information
MarkoSagadin committed Nov 19, 2024
1 parent f9c94a5 commit 1913efe
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased]

### Fixed

- A bug where installed `v2.8.0-rc1` toolchain would be confused for `v2.8.0`.

## [0.24.0] - 2024-11-07

### Added
Expand Down
2 changes: 1 addition & 1 deletion src/east/east_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ def pre_workspace_command_check(
# Check if toolchain for detected ncs version is supported
result = self.run_manager("search --show-all", silent=True, return_output=True)

if self.detected_ncs_version in result["output"]:
if self.detected_ncs_version == result["output"]:
# Supported but not installed, should we exit program or silently pass?
if ignore_uninstalled_ncs:
return
Expand Down

0 comments on commit 1913efe

Please sign in to comment.