Skip to content

Commit

Permalink
Remove trailing slashes from the Codechecker URL
Browse files Browse the repository at this point in the history
  • Loading branch information
MarkoSagadin committed Feb 28, 2024
1 parent e9ee90b commit 6f825ba
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased]

### Fixed

- Strip away trailing slashes from Codechecker server URL that could cause
problems when creating the endpoint URL. This affects the
`east codechecker store` and `east codechecker servdiff`, which get the URL
either as a command line argument or from the environmental variable
`EAST_CODECHECKER_SERVER_URL`

## [0.17.4] - 2024-01-08

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions src/east/workspace_commands/codechecker_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ def store(east, url, build_dir):
endpoint = get_endpoint(east)

store_cmd = (
f"{cc} store --name '{name}' --url {url}/{endpoint} "
f"{cc} store --name '{name}' --url {url.strip('/')}/{endpoint} "
f"--config {cfg} {cc_output_dir} --tag '{tag}'"
)

Expand Down Expand Up @@ -393,7 +393,7 @@ def servdiff(east, new, resolved, unresolved, html, url, build_dir):

diff_cmd = (
f"{cc} cmd diff --basename {name} --newname {cc_output_dir} "
f"--url {url}/{endpoint} "
f"--url {url.strip('/')}/{endpoint} "
)

if [new, resolved, unresolved].count(True) != 1:
Expand Down

0 comments on commit 6f825ba

Please sign in to comment.