refactor: 교육 시작 시 캐시에 정답 저장 메서드 위치 변경

IT-Cotato · Aug 14, 2024 · 0aab669 · 0aab669
1 parent 8cfc503
commit 0aab669
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/org/cotato/csquiz/api/socket/controller/SocketController.java b/src/main/java/org/cotato/csquiz/api/socket/controller/SocketController.java
@@ -34,7 +34,6 @@ public class SocketController {
     @PatchMapping("/start/csquiz")
     public ResponseEntity<Void> openCSQuiz(@RequestBody @Valid QuizOpenRequest request) {
         educationService.openCSQuiz(request);
-        recordService.saveAnswersToCache(request);
         return ResponseEntity.noContent().build();
     }
 

diff --git a/src/main/java/org/cotato/csquiz/domain/education/service/EducationService.java b/src/main/java/org/cotato/csquiz/domain/education/service/EducationService.java
@@ -32,6 +32,7 @@
 @Slf4j
 public class EducationService {
 
+    private final RecordService recordService;
     private final EducationRepository educationRepository;
     private final QuizRepository quizRepository;
     private final SessionRepository sessionRepository;
@@ -93,6 +94,7 @@ public void openCSQuiz(QuizOpenRequest request) {
         checkEducationBefore(education);
 
         education.updateStatus(EducationStatus.ONGOING);
+        recordService.saveAnswersToCache(education.getId());
     }
 
     private void checkEducationBefore(Education education) {

diff --git a/src/main/java/org/cotato/csquiz/domain/education/service/RecordService.java b/src/main/java/org/cotato/csquiz/domain/education/service/RecordService.java
@@ -12,7 +12,6 @@
 import org.cotato.csquiz.api.record.dto.ReplyRequest;
 import org.cotato.csquiz.api.record.dto.ReplyResponse;
 import org.cotato.csquiz.api.record.dto.ScorerResponse;
-import org.cotato.csquiz.api.socket.dto.QuizOpenRequest;
 import org.cotato.csquiz.api.socket.dto.QuizSocketRequest;
 import org.cotato.csquiz.common.error.ErrorCode;
 import org.cotato.csquiz.common.error.exception.AppException;
@@ -96,8 +95,8 @@ private Quiz findQuizById(Long quizId) {
                 .orElseThrow(() -> new EntityNotFoundException("해당 문제를 찾을 수 없습니다."));
     }
 
-    public void saveAnswersToCache(QuizOpenRequest request) {
-        List<Quiz> quizzes = quizRepository.findAllByEducationId(request.educationId());
+    public void saveAnswersToCache(final Long educationId) {
+        List<Quiz> quizzes = quizRepository.findAllByEducationId(educationId);
 
         quizAnswerRedisRepository.saveAllQuizAnswers(quizzes);
     }