Skip to content

Commit

Permalink
refactor: 로고 이미지 URL만 가져오도록 수정 및 코드 가독성 개선
Browse files Browse the repository at this point in the history
- api path 수정
- 로고 사진에 대한 url만 가져오게 변경
- 코드 가독성 향상 위한 수정
- 코드 컨텐션 통일을 위한 공백 추가 및 삭제
  • Loading branch information
yunhacandy committed Aug 16, 2024
1 parent d174e41 commit e5c4289
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ public ResponseEntity<ProjectDetailResponse> getProjectDetail(@PathVariable("pro
}

@Operation(summary = "프로젝트 목록 조회 API")
@GetMapping("")
@GetMapping
public ResponseEntity<List<ProjectSummaryResponse>> getAllProjectSummaries() {
List<ProjectSummaryResponse> projectSummaries = projectService.getAllProjectSummaries();
return ResponseEntity.ok(projectSummaries);
return ResponseEntity.ok(projectService.getAllProjectSummaries());
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,21 +9,16 @@ public record ProjectSummaryResponse(
String introduction,
Long generationId,
Integer generationNumber,
ProjectImageInfoResponse logo
String imageurl
) {
public static ProjectSummaryResponse of(Project project, Integer generationNumber, ProjectImage logoImage) {
ProjectImageInfoResponse logoInfoResponse = null;
if (logoImage != null) {
logoInfoResponse = ProjectImageInfoResponse.from(logoImage);
}

public static ProjectSummaryResponse of(Project project, Integer generationNumber, ProjectImage projectImage) {
return new ProjectSummaryResponse(
project.getId(),
project.getName(),
project.getIntroduction(),
project.getGenerationId(),
generationNumber,
logoInfoResponse
projectImage != null ? projectImage.getS3Info().getUrl() : null
);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@
public interface ProjectImageRepository extends JpaRepository<ProjectImage, Long> {
List<ProjectImage> findAllByProjectId(Long projectId);
Optional<ProjectImage> findByProjectIdAndProjectImageType(Long projectId, ProjectImageType projectImageType);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import jakarta.persistence.EntityNotFoundException;
import java.util.List;
import java.util.Optional;
import java.util.stream.Collectors;
import lombok.RequiredArgsConstructor;
import org.cotato.csquiz.api.project.dto.ProjectDetailResponse;
import org.cotato.csquiz.api.project.dto.ProjectSummaryResponse;
Expand Down Expand Up @@ -51,7 +50,6 @@ public List<ProjectSummaryResponse> getAllProjectSummaries(){
Integer generationNumber = generationRepository.findGenerationNumberByGenerationId(project.getGenerationId());

return ProjectSummaryResponse.of(project, generationNumber, logoImage.orElse(null));
}).collect(Collectors.toList());
}).toList();
}

}

0 comments on commit e5c4289

Please sign in to comment.