Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: S3 예외 코드 분리 및 에러 메세지 변경 #102

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Refactor: S3 예외 코드 분리 및 에러 메세지 변경 #102

merged 1 commit into from
Aug 17, 2024

Conversation

gikhoon
Copy link
Member

@gikhoon gikhoon commented Aug 16, 2024

연관된 이슈

이슈링크(url):

✅ 작업 내용

  • convert 에러 -> IMAGE_CONVERT_FAIL 로 변경
  • AmazonS3Exception 이 기존의 IMAGE_PROCESSING_FAIL 사용
  • 확장자가 없을 때 예외 메세지 변경

🗣 ️리뷰 요구 사항

@gikhoon
refactor: S3 예외 메세지 변경
240ea84 
- convert 에러 -> IMAGE_CONVERT_FAIL 로 변경
- AmazonS3Exception 이 기존의 IMAGE_PROCESSING_FAIL 사용
- 확장자가 없을 때 예외 메세지 변경
@gikhoon gikhoon self-assigned this Aug 16, 2024
Youthhing
Youthhing approved these changes Aug 17, 2024
View reviewed changes
Copy link
Member

@Youthhing Youthhing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~

@gikhoon gikhoon merged commit 99d6acf into develop Aug 17, 2024
1 check passed
@gikhoon gikhoon deleted the refactor/#MF-17-2-s3-exception-renaming branch August 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youthhing Youthhing Youthhing approved these changes

Assignees

@gikhoon gikhoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gikhoon @Youthhing