-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: 세션 사진 수 증가 #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- SessionPhoto 테이블을 Session과 양방향 매핑으로 구축
- 순서가 0 이하거나 총 저장 사진보다 클 경우 예외 발생
- url, 순서 추가
- 사진 수정 로직 삭제
Youthhing
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
변경 사항이 많아서 리뷰가 좀 길었네요. 읽고 의견 남겨주시면 감사하겠습니다!
src/main/java/org/cotato/csquiz/api/session/controller/SessionController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/api/session/dto/AddSessionPhotoResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/api/session/dto/AddSessionRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/entity/SessionPhoto.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/entity/SessionPhoto.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/entity/SessionPhoto.java
Show resolved
Hide resolved
추가로 리뷰 요구 사항에 적힌 DDL도 별도로 PR란에 적으면 좋을 듯 합니다! |
- /description -> /update로 통합 - /update/photo -> POST DELETE /photo로 분화
- null, empty인지 판단하는 로직 추가
- 중복된 순서가 있는지 확인
Youthhing
approved these changes
Jul 4, 2024
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/entity/SessionPhoto.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Outdated
Show resolved
Hide resolved
Youthhing
reviewed
Jul 4, 2024
src/main/java/org/cotato/csquiz/domain/generation/service/SessionService.java
Show resolved
Hide resolved
@gikhoon 테이블 변경에 따른 수정해야할 DDL 해당 PR에 정리 부탁드립니다! |
This was referenced Jul 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
이슈링크(url): #22
✅ 작업 내용
🗣 ️리뷰 요구 사항
DDL 수정사항