Feature: 부원들 출석 정보 열람 기능 구현 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: 관리자가 출석부를 가져오는 기능 구현
- member, admin으로 나누지 않고 하나로 통합 - security 설정 변경 - Controller 파일명 변경 refactor: 출석 컨트롤러 API명 변경
- AdminService로 부터 출석기록 정보가 사용되는 부분을 RecordService로 분리
- 기존 멤버 하나씩 정보를 만드는 방식에서 활동 중인 회원 목록을 가져와 Map으로 만들게 변경 feat: 출석 목록에 해당하는 멤버 정보 받는 방식 변경 - 기존 멤버 하나씩 정보를 만드는 방식에서 활동 중인 회원 목록을 가져와 Map으로 만들게 변경
gikhoon
force-pushed
the
feature/#TA-6-admin-attendance-record
branch
from
800ac8f
to
e2d12d2
Compare
|
@Youthhing
|
Youthhing
reviewed
Aug 1, 2024
src/main/java/org/cotato/csquiz/api/attendance/controller/AttendanceController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/api/attendance/controller/AttendanceController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/AttendanceAdminService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/AttendanceAdminService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/auth/enums/MemberRole.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/auth/service/MemberService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/api/attendance/dto/AttendanceRecordResponse.java
Outdated
Show resolved
Hide resolved
Youthhing
reviewed
Aug 1, 2024
src/main/java/org/cotato/csquiz/api/attendance/dto/AttendanceRecordResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/AttendanceRecordService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/api/attendance/dto/AttendanceRecordResponse.java
Outdated
Show resolved
Hide resolved
Youthhing
approved these changes
Aug 2, 2024
src/main/java/org/cotato/csquiz/domain/auth/enums/MemberRole.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/AttendanceRecordService.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/AttendanceRecordService.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관된 이슈
이슈링크(url): #78
✅ 작업 내용
🗣 ️리뷰 요구 사항
고민 중인 상황
fetch join으로 연결하려 했으나 출석정보 - 멤버가 명시적 연관(Member)가 아니라 (memberId)로 연관되어 있어 불가능
어떤 식으로 해결 해야 할 지 고민 중
따라서 출석상태(AttendanceStatus)에 "결석" 항목을 넣을 건지? 고민 중
현재는 "진행한 모든 출석 수 - record에 들어간 멤버의 출석 수"로 결석을 계산함
DDL 변경