Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: 대면 비대면 출석 기능 구현 #87

Merged
merged 18 commits into from
Aug 8, 2024
Merged

Feature: 대면 비대면 출석 기능 구현 #87

merged 18 commits into from
Aug 8, 2024

Conversation

Youthhing
Copy link
Member

@Youthhing Youthhing commented Aug 7, 2024 •
edited
Loading

✅ 작업 내용

  • 다형성을 활용한 대면, 비대면 출석 참고자료
  • Util 클래스를 활용한 출결 시간 구분 로직 구현
  • 출석 기록 member_index 추가

🗣 ️리뷰 요구 사항

DDL 변경

index 추가

create index member_id_index
    on attendance_record (member_id);
    ```

gikhoon
gikhoon reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@gikhoon gikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 남겼습니다

src/main/java/org/cotato/csquiz/domain/attendance/entity/AttendanceRecord.java Outdated Show resolved Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/entity/AttendanceRecord.java Show resolved Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/RequestAttendanceService.java Show resolved Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/util/AttendanceUtil.java Show resolved Hide resolved
@Youthhing Youthhing requested a review from gikhoon August 8, 2024 02:26
gikhoon
gikhoon reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@gikhoon gikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료했습니다

src/test/java/org/cotato/csquiz/CsquizApplicationTests.java Outdated Show resolved Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/OfflineAttendClient.java Outdated Show resolved Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/OnlineAttendClient.java Show resolved Hide resolved
src/main/java/org/cotato/csquiz/domain/attendance/service/RequestAttendanceService.java Show resolved Hide resolved
@Youthhing Youthhing requested a review from gikhoon August 8, 2024 06:39
gikhoon
gikhoon reviewed Aug 8, 2024
View reviewed changes
Copy link
Member

@gikhoon gikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

관리자가 범위내에서 출석 시간을 바꿨을때 기록이 일괄적으로 바뀌게 설정해주시면 될것 같습니다

@Youthhing Youthhing merged commit 59de1d6 into develop Aug 8, 2024
1 check passed
@Youthhing Youthhing deleted the feature/#TA-7-attendance-record branch August 8, 2024 16:47
@Youthhing Youthhing mentioned this pull request Aug 9, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gikhoon gikhoon gikhoon approved these changes

Assignees

@Youthhing Youthhing

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Youthhing @gikhoon