Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprint MartinKippenberger: Minor Improvements #1768

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
7fc502d
wip1
mrnicegyu11 Oct 22, 2024
cd9bafe
Add martinKippenberger Sprint Review Draft Doc
mrnicegyu11 Oct 22, 2024
97d84ee
Add martinKippenberger Sprint Review Draft Doc -2
mrnicegyu11 Oct 22, 2024
1d3c8b0
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 22, 2024
3b46df6
Update 20241028_MartinKippenberger.md
Konohana0608 Oct 22, 2024
ba990c7
updates PC, cleanup links and md layout
pcrespov Oct 22, 2024
34ff582
updates PC
pcrespov Oct 22, 2024
2e203a9
updates PC timing and missed issues
pcrespov Oct 22, 2024
f358f1a
reduced timings and formatting
pcrespov Oct 22, 2024
c62d5b6
SAN updates
sanderegg Oct 22, 2024
8c149e4
Update 20241028_MartinKippenberger.md
wvangeit Oct 23, 2024
ba66e4e
Update 20241028_MartinKippenberger.md
jsaq007 Oct 23, 2024
2ac626e
Update 20241028_MartinKippenberger.md
odeimaiz Oct 23, 2024
296c7d5
Update 20241028_MartinKippenberger.md
odeimaiz Oct 23, 2024
5f591d3
Update 20241028_MartinKippenberger.md
YuryHrytsuk Oct 24, 2024
64b1a9a
Update 20241028_MartinKippenberger.md
YuryHrytsuk Oct 24, 2024
9653c28
Update 20241028_MartinKippenberger.md
YuryHrytsuk Oct 24, 2024
1a667ea
Update 20241028_MartinKippenberger.md
SCA-ZMT Oct 24, 2024
3743671
mag
mguidon Oct 24, 2024
a2014ff
Update 20241028_MartinKippenberger.md
matusdrobuliak66 Oct 24, 2024
8acf800
Update 20241028_MartinKippenberger.md
matusdrobuliak66 Oct 24, 2024
023f58a
SAN updates
sanderegg Oct 24, 2024
60d9250
Update 20241028_MartinKippenberger.md
odeimaiz Oct 24, 2024
0c21d69
SAN
sanderegg Oct 24, 2024
46ee23b
SAN
sanderegg Oct 24, 2024
ebb85c6
maintenance
sanderegg Oct 24, 2024
dff751a
update
sanderegg Oct 24, 2024
3d19efd
Update 20241028_MartinKippenberger.md
matusdrobuliak66 Oct 24, 2024
8a494d8
Update 20241028_MartinKippenberger.md
matusdrobuliak66 Oct 24, 2024
6a60866
IP changes
ignapas Oct 24, 2024
66c8583
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 24, 2024
1b783db
san
sanderegg Oct 24, 2024
d440915
Update 20241028_MartinKippenberger.md
JavierGOrdonnez Oct 24, 2024
3a7bf8c
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 24, 2024
e9a9c14
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 24, 2024
655de58
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 24, 2024
9d3c57c
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 24, 2024
2826edd
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 24, 2024
7248334
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 24, 2024
2525645
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 24, 2024
272c256
Update 20241028_MartinKippenberger.md
mrnicegyu11 Oct 24, 2024
bd8a2e8
ReleaseNote Improvement
mrnicegyu11 Oct 29, 2024
51de95c
ReleaseNote Improvement - 2
mrnicegyu11 Oct 29, 2024
4ecd5a4
Add v1.78.0 draft release notes - 3
mrnicegyu11 Oct 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add v1.78.0 draft release notes - 3
  • Loading branch information
mrnicegyu11 committed Oct 29, 2024
commit 4ecd5a4fc7de089bb756d3e0b0b608c796d696e7
60 changes: 36 additions & 24 deletions scripts/3_deadlines_calendar.py
Original file line number Diff line number Diff line change
@@ -1,24 +1,25 @@
import argparse
from datetime import datetime
from typing import Final

from utils import validate_date

TEMPLATE: Final[
str
] = """

## Deadlines & upcoming schedule
`{prs_merge}`: @all have all your PRs intended to be tested merged by the end of the day
`{staging_release}`: STAGING release
`{review_meeting}`: REVIEW MEETING
`{review_meeting}`: by the end of the day created draft of the release notes
`{start_app_team}`: -> {end_app_team}: App Team has exclusive access to the AWS Staging environment
`{prod_release}`: PROD release
] = """## Deadlines & upcoming schedule
{sorted_events}
Comment on lines +7 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this version way less readable. I preferred the declarative template approach.

"""


def validate_date(date_str: str) -> datetime:
try:
return datetime.strptime(date_str, "%d.%m")
except ValueError:
raise argparse.ArgumentTypeError(
f"Invalid date format: '{date_str}'. Expected format is dd.mm."
)


def main() -> None:
parser = argparse.ArgumentParser(description="Assemble deadelines calendar")
parser = argparse.ArgumentParser(description="Assemble deadlines calendar")
for date in [
"prs_merge",
"staging_release",
@@ -28,22 +29,33 @@ def main() -> None:
"prod_release",
]:
parser.add_argument(
date,
type=validate_date,
help="The date is in the format dd.mm",
date, type=validate_date, help="The date is in the format dd.mm"
)
args = parser.parse_args()
print(f"\nDeadlines: {args}")

mattermost_message = TEMPLATE.format(
prs_merge=args.prs_merge,
staging_release=args.staging_release,
review_meeting=args.review_meeting,
start_app_team=args.start_app_team,
end_app_team=args.end_app_team,
prod_release=args.prod_release,
events = [
(
args.prs_merge,
"`{}`: @all have all your PRs intended to be tested merged by the end of the day",
),
(args.staging_release, "`{}`: STAGING release"),
(args.review_meeting, "`{}`: REVIEW MEETING"),
(
args.review_meeting,
"`{}`: by the end of the day created draft of the release notes",
),
(
args.start_app_team,
"`{}` -> `{}`: App Team has exclusive access to the AWS Staging environment",
),
(args.prod_release, "`{}`: PROD release"),
]
events.sort()
sorted_events = "\n".join(
event[1].format(event[0].strftime("%d.%m"), args.end_app_team.strftime("%d.%m"))
for event in events
)

mattermost_message = TEMPLATE.format(sorted_events=sorted_events)
print(f"\n{mattermost_message}\n")


2 changes: 1 addition & 1 deletion scripts/4_make_release_drafts.py
Original file line number Diff line number Diff line change
@@ -37,7 +37,7 @@

_MATTERMOST_TEMPLATE: str = """
@all please contribute in compiling the `Release Drafts`.
There are 3 release drafts to fill out: `s4l` (which also includes s4li-lite), `osparc`, `tip`.
There are 3 release drafts to fill out: `s4l` (which also includes s4l-lite), `osparc`, `tip`.
Instructions:
- Please go through all your last changes in master since the last release for each product: [osparc](https://github.com/ITISFoundation/osparc-issues/blob/master/release-notes/osparc/{version_tag}.md), [s4l](https://github.com/ITISFoundation/osparc-issues/blob/master/release-notes/s4l/{version_tag}.md) and [tip](https://github.com/ITISFoundation/osparc-issues/blob/master/release-notes/tip/{version_tag}.md) (each product contains a link to these changes)
- For each product please chose those features which it makes sense to highlight.