-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔨 adding helper release monitoring script #4504
🔨 adding helper release monitoring script #4504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great tool and very nice display, just I would I think more go with an .env file instead of so many ENVs. you could even generate the .env file by calling --config
or so...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I left some comments.
Since this is a tool, i would like to propose you to do a little experiment. What about using https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/
a) instead of the requirements
b) to include an entrypoint
this way the tool is "installable" and called as an executable i.e. monitor-release --help
very cool thanks a lot! |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I understand we just use them "as is" without any of the suggested changes, right? :-)
I made changes regarding your request:
yes other than that i am using that tool and for now the code changes are sufficient. |
… github.com:matusdrobuliak66/osparc-simcore into maintenance/adding-helper-release-monitoring-script
Code Climate has analyzed commit c808bb9 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
🔨 Helper script:
Check the current status of containers
monitor-release master containers
Check currently running sidecars:
monitor-release master sidecars
Related issue/s
How to test
DevOps Checklist