Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 adding helper release monitoring script #4504

Conversation

matusdrobuliak66
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 commented Jul 18, 2023

What do these changes do?

🔨 Helper script:

  • Check the current status of containers
    monitor-release master containers
    image

  • Check currently running sidecars:
    monitor-release master sidecars
    image

Related issue/s

How to test

DevOps Checklist

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jul 18, 2023
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review July 18, 2023 14:31
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great tool and very nice display, just I would I think more go with an .env file instead of so many ENVs. you could even generate the .env file by calling --config or so...

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I left some comments.

Since this is a tool, i would like to propose you to do a little experiment. What about using https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/
a) instead of the requirements
b) to include an entrypoint

this way the tool is "installable" and called as an executable i.e. monitor-release --help

@mrnicegyu11
Copy link
Member

very cool thanks a lot!

@pcrespov pcrespov added this to the Sundae milestone Jul 19, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@matusdrobuliak66 matusdrobuliak66 modified the milestones: Sundae, the nameless Sep 26, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I understand we just use them "as is" without any of the suggested changes, right? :-)

@matusdrobuliak66
Copy link
Contributor Author

So I understand we just use them "as is" without any of the suggested changes, right? :-)

I made changes regarding your request:

Since this is a tool, i would like to propose you to do a little experiment. What about using https://pip.pypa.io/en/stable/reference/build-system/pyproject-toml/
a) instead of the requirements
b) to include an entrypoint
this way the tool is "installable" and called as an executable i.e. monitor-release --help

yes other than that i am using that tool and for now the code changes are sufficient.

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) September 26, 2023 19:29
… github.com:matusdrobuliak66/osparc-simcore into maintenance/adding-helper-release-monitoring-script
@codeclimate
Copy link

codeclimate bot commented Sep 27, 2023

Code Climate has analyzed commit c808bb9 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@matusdrobuliak66 matusdrobuliak66 merged commit 7015005 into ITISFoundation:master Sep 27, 2023
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants