♻️ directorv2 API schema models moved to models-library

[pcrespov]

What do these changes do?

This PR moves the pydantic models in the director-v2 API (i.e. models/schemas) to models_library.api_schemas_directorv2. This way both server and client can share these models.
Changes only affect the director-v2 and models_library packages and the corresponding clients (e.g. web-server or api-server will be done in separate PRs).

• ♻️ Moves directorv2's schemas to models-library.api_schemas_director_v2 and leaves in the service only domain models.

• @sanderegg please follow up this PR by reviewing the openapi.json and the models in models_library.api_schemas_directorv2. After ♻️Maintenance: remove unused routes from director v2 #4462 the OAS changed but the openapi.json was not updated. Could you please have a look?.

Related issue/s

• Follows from ♻️ catalog API schema models moved to models-library #4553
• Related to Major upgrade to pydantic 2.0 #4481: cleanup models-library
• API: directorv2 schema models moved to models-library

How to test

• driving test: packages/models-library/tests/test__models_examples.py
• current tests in directorv2

DevOps

None

[codecov]

Codecov Report

Merging #4560 (2e53571) into master (72787f8) will decrease coverage by 1.1%.
The diff coverage is 95.3%.

@@           Coverage Diff            @@
##           master   #4560     +/-   ##
========================================
- Coverage    85.6%   84.6%   -1.1%     
========================================
  Files        1007     842    -165     
  Lines       43186   38635   -4551     
  Branches     1001     495    -506     
========================================
- Hits        36996   32701   -4295     
+ Misses       5961    5827    -134     
+ Partials      229     107    -122     

Flag	Coverage Δ
integrationtests	39.5% <ø> (-38.4%)	⬇️
unittests	84.4% <95.3%> (+0.2%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...ages/models-library/src/models_library/services.py	91.3% <ø> (ø)
..._service_catalog/models/services_specifications.py	100.0% <ø> (ø)
...or-v2/src/simcore_service_director_v2/constants.py	100.0% <ø> (ø)
...ynamic_sidecar/scheduler/_core/_scheduler_utils.py	79.0% <69.2%> (-3.8%)	⬇️
...odels_library/api_schemas_directorv2/comp_tasks.py	87.5% <71.4%> (ø)
...service_director_v2/api/routes/dynamic_services.py	88.7% <75.0%> (-0.9%)	⬇️
.../models_library/api_schemas_directorv2/clusters.py	87.3% <100.0%> (ø)
...library/api_schemas_directorv2/dynamic_services.py	95.6% <100.0%> (ø)
...api_schemas_directorv2/dynamic_services_service.py	97.2% <100.0%> (ø)
...rc/models_library/api_schemas_directorv2/errors.py	100.0% <100.0%> (ø)
... and 45 more

... and 188 files with indirect coverage changes

[codeclimate]

Code Climate has analyzed commit 2e53571 and detected 0 issues on this pull request.

View more on Code Climate.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[matusdrobuliak66]

👍

[GitHK]

As a rule of thumb I would not move things away from director-v2. Especially if they are only used internally.