Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ WIP: Upgrade to pydantic 2 #6266

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Aug 29, 2024

What do these changes do?

Migrate the libraries/services to pydantic version 2.

Related issue/s

How to test

Dev-ops checklist

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.5%. Comparing base (cafbf96) to head (7dace12).
Report is 504 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6266      +/-   ##
=========================================
- Coverage    84.5%   55.5%   -29.1%     
=========================================
  Files          10      54      +44     
  Lines         214    2595    +2381     
  Branches       25       0      -25     
=========================================
+ Hits          181    1441    +1260     
- Misses         23    1154    +1131     
+ Partials       10       0      -10     
Flag Coverage Δ
unittests 55.5% <ø> (-29.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 64 files with indirect coverage changes

@giancarloromeo giancarloromeo added the t:maintenance Some planned maintenance work label Sep 2, 2024
@giancarloromeo giancarloromeo added this to the Eisbock milestone Sep 2, 2024
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ask for a review one more time when ready. thanks

Copy link

sonarcloud bot commented Sep 7, 2024

@giancarloromeo giancarloromeo deleted the is4481/upgrade-to-pydantic2 branch September 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Major upgrade to pydantic 2.0
3 participants