-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ add project tags to RUT listing/export #6722
✨ add project tags to RUT listing/export #6722
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6722 +/- ##
==========================================
+ Coverage 87.72% 88.60% +0.87%
==========================================
Files 1570 1373 -197
Lines 63320 56528 -6792
Branches 2119 1131 -988
==========================================
- Hits 55550 50086 -5464
+ Misses 7443 6267 -1176
+ Partials 327 175 -152
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great!
packages/postgres-database/src/simcore_postgres_database/models/projects_tags.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/projects_tags.py
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/models/projects_tags.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pleas check the project.id field which looks strange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
packages/postgres-database/src/simcore_postgres_database/models/projects_tags.py
Show resolved
Hide resolved
.../simcore_service_resource_usage_tracker/services/modules/db/repositories/resource_tracker.py
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
@odeimaiz I was thinking it might be useful to show a pop-up when a user is deleting a tag, indicating that the tag will also be removed from the Resource Usage history |
7e1ccbd
into
ITISFoundation:master
What do these changes do?
Goal/Current Use Case:
Current Challenges:
project_tags
table poses an issue: if a project is deleted, its information would be lost and would no longer be listed. (Currently, the RUT maintains the complete history of runs, so it needs access to the project tags even after the project are deleted.)Proposed Solutions:
Primary Solution:
Use the
project_tags
table, but instead of deleting rows when a project is deleted, mark them as deleted. This ensures they are not listed anymore but remain accessible for historical purposes.Alternative Solution:
Keep a second copy of the
project_tags
table in the RUT. However, this introduces challenges in maintaining synchronization—not only when a tag is added or removed from a project, but also when the tag resource itself is deleted or updated. (started to implement but I do not think it is a good way to go:WIP: ✨ adding tags to RUT #6708)I found solution 1. more reasonable to implement.
Implemented behavior:
Related issue/s
How to test
Dev-ops checklist