Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Fix unit tests after master merge #6727

Conversation

giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Nov 15, 2024

What do these changes do?

Fix unit tests after master merge:

  • WebServer 01-04
  • API Server
  • Datcore-adapter

Related issue/s

How to test

Dev-ops checklist

@giancarloromeo giancarloromeo added this to the Event Horizon milestone Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 60.71429% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (44bc9f7) to head (12710c9).
Report is 1 commits behind head on pydantic_v2_migration_do_not_squash_updates.

Additional details and impacted files
@@                               Coverage Diff                                @@
##           pydantic_v2_migration_do_not_squash_updates    #6727       +/-   ##
================================================================================
+ Coverage                                        67.96%   81.03%   +13.06%     
================================================================================
  Files                                             1427     1232      -195     
  Lines                                            57729    55163     -2566     
  Branches                                          2229     1013     -1216     
================================================================================
+ Hits                                             39238    44700     +5462     
+ Misses                                           18157    10321     -7836     
+ Partials                                           334      142      -192     
Flag Coverage Δ *Carryforward flag
integrationtests 53.36% <ø> (+0.02%) ⬆️ Carriedforward from fb2ed15
unittests 85.79% <60.71%> (+2.61%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 91.23% <28.57%> (-0.09%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.00% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 78.26% <ø> (ø)
agent 97.01% <ø> (ø)
api_server 89.66% <100.00%> (∅)
autoscaling ∅ <ø> (∅)
catalog 90.57% <ø> (ø)
clusters_keeper 98.73% <ø> (ø)
dask_sidecar 90.87% <ø> (ø)
datcore_adapter 93.17% <100.00%> (∅)
director 58.38% <ø> (ø)
director_v2 76.29% <ø> (ø)
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 59.79% <ø> (ø)
efs_guardian 90.12% <ø> (ø)
invitations 93.49% <ø> (ø)
osparc_gateway_server 85.74% <ø> (ø)
payments 92.77% <ø> (ø)
resource_usage_tracker 90.76% <ø> (+0.15%) ⬆️
storage 89.66% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 80.08% <90.90%> (+39.47%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44bc9f7...12710c9. Read the comment docs.

Copy link

sonarcloud bot commented Nov 15, 2024

@giancarloromeo giancarloromeo changed the title Fix unit tests after master merge ♻️ Fix unit tests after master merge Nov 15, 2024
@giancarloromeo giancarloromeo marked this pull request as ready for review November 15, 2024 09:11
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@giancarloromeo giancarloromeo merged commit a2d3742 into ITISFoundation:pydantic_v2_migration_do_not_squash_updates Nov 15, 2024
67 of 75 checks passed
@giancarloromeo giancarloromeo deleted the fix-unit-tests-after-master-merge branch November 15, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants