Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test code to be less redundant #320

Merged
merged 14 commits into from
Nov 21, 2024
Merged

Refactor test code to be less redundant #320

merged 14 commits into from
Nov 21, 2024

Conversation

stoftot
Copy link
Collaborator

@stoftot stoftot commented Nov 21, 2024

No description provided.

@stoftot stoftot added refactor Refactoring the code test Tests for the code labels Nov 21, 2024
@stoftot stoftot linked an issue Nov 21, 2024 that may be closed by this pull request
As a developer, I want to refactor our test code to be less redundant #319
Closed
RasmusLarsen02
RasmusLarsen02 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@RasmusLarsen02 RasmusLarsen02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good nice refactor, way more readable, should improve extensibility aswell

@RasmusLarsen02 RasmusLarsen02 merged commit 24cae22 into main Nov 21, 2024
6 checks passed
@RasmusLarsen02 RasmusLarsen02 deleted the refactor-test-code-to-be-less-redundant branch November 21, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusLarsen02 RasmusLarsen02 RasmusLarsen02 approved these changes

Assignees
No one assigned
Labels
refactor Refactoring the code test Tests for the code
Projects
ITU-BDSA2024-GROUP10 Chirp
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As a developer, I want to refactor our test code to be less redundant
2 participants
@stoftot @RasmusLarsen02