Skip to content

✨ feat: 채팅방 매물 가격 정보 단위 표시 수정#75

Merged
leeedongjaee merged 2 commits intodevelopfrom
feature/chat
Aug 9, 2025
Merged

✨ feat: 채팅방 매물 가격 정보 단위 표시 수정#75
leeedongjaee merged 2 commits intodevelopfrom
feature/chat

Conversation

@leeedongjaee
Copy link
Contributor

@leeedongjaee leeedongjaee commented Aug 9, 2025

🚀 관련 이슈

#2

🔑 주요 변경사항

  • 채팅방 매물 상단 매물 가격정보 표기 수정

✔️ 체크 리스트

  • Merge 하려는 브랜치가 올바른가? (main branch에 실수로 PR 생성 금지)
  • Merge 하려는 PR 및 Commit들을 로컬에서 실행했을 때 에러가 발생하지 않았는가?
  • 라벨을 등록했는가?
  • 리뷰어를 지정했는가?

📢 To Reviewers

📸 스크린샷 or 실행영상

↗️ 개선 사항

Summary by CodeRabbit

  • 개선 사항
    • 보증금과 월세 금액 표기가 더욱 읽기 쉽도록 "억" 단위와 "만원"/"원" 단위로 세분화되어 표시됩니다.
    • 월세가 0일 경우 빈 문자열로 처리되어 불필요한 정보가 표시되지 않습니다.

@coderabbitai
Copy link

coderabbitai bot commented Aug 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

SQL 쿼리 내에서 deposit_pricemonthly_rent의 금액 표시 방식을 개선하는 로직이 추가되었습니다. 1억 원 이상의 금액에 대해 "억" 단위와 "만원"/"원" 단위를 조합하여 조건부로 표기하며, 기존에는 단순히 "만원" 단위로만 표기하던 부분이 세분화되었습니다. 기타 컬럼이나 조인 조건에는 변경이 없습니다.

Changes

Cohort / File(s) Change Summary
채팅방 금액 표기 로직 개선
src/main/resources/org/scoula/domain/chat/mapper/ChatRoomMapper.xml
deposit_pricemonthly_rent의 SQL 내 금액 표기 방식을 1억 단위 이상일 때 "억"과 "만원"/"원"을 조합해 조건부로 표기하도록 변경. 기존에는 단순 "만원" 단위 표기만 사용. 기타 쿼리 구조에는 변화 없음.

Sequence Diagram(s)

(해당 변경은 SQL 내 문자열 포맷팅 로직 개선에 국한되어 있으므로, 시퀀스 다이어그램 생성이 적합하지 않습니다.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective Addressed Explanation
계약 전 채팅 로직 및 채팅 리스트 API 구현 (#1)
SSE 활용한 채팅 알림 구현 (#1) SSE 관련 기능 또는 알림 로직 변경 사항이 없음.
임대인/임차인 간 실시간 채팅, WebSocket+STOMP, 데이터 동기화 등 실시간 처리 (#1) 본 변경은 금액 표기 로직에 한정되어 있어 실시간 처리 및 메시징 로직과의 직접적 연관이 불분명함.

Assessment against linked issues: Out-of-scope changes

(연결된 이슈의 목적 외 변경 사항은 발견되지 않았습니다.)

Poem

금액 표기, 억 단위로 똑똑하게,
만원과 원이 어우러진 채,
채팅방 쿼리도 한층 더 세련되네!
SQL 속 숫자들도 토끼처럼 깡총,
채팅방에 기쁨이 번져나가네.
🐇💬💸

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 893b208 and 9a4acee.

📒 Files selected for processing (1)
  • src/main/resources/org/scoula/domain/chat/mapper/ChatRoomMapper.xml (1 hunks)
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/chat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@leeedongjaee leeedongjaee merged commit d51f3a7 into develop Aug 9, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] 이슈 제목

1 participant