Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough계약 대기 API 제거, 계약 단계 및 메시징 흐름 재구성, Redis 기반 nextSteps 합의 로직 도입, 사용자 검증(임대인/임차인) 강화, ContractMapper에 소유자/임차인 조회 추가 및 identity_verification 조인으로 계약 조회 변경, 사전계약 서비스/구현체를 Tenant*로 리네이밍, STEP0 상태 업데이트 추가. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ContractController
participant ContractService
participant Redis
participant ChatService
Client->>ContractController: POST /contract/{id}/nextStep
ContractController->>ContractService: nextStep(id, userId, dto)
ContractService->>Redis: HGET/HSET readiness (owner/buyer)
Redis-->>ContractService: readiness state
alt both ready
ContractService->>ChatService: AI message: 다음 단계 안내/금액 조율 안내
ContractService-->>ContractController: true
else waiting
ContractService-->>ContractController: false
end
ContractController-->>Client: {ready: true|false}
sequenceDiagram
participant Client
participant ContractController
participant ContractService
participant Mapper
participant ChatService
Client->>ContractController: GET /contract/{id}/next
ContractController->>ContractService: getContractNext(id, userId)
ContractService->>Mapper: getOwnerId/getBuyerId + 계약 정보
Mapper-->>ContractService: IDs/계약 DTO
ContractService->>ChatService: AI message: 정보조회 시작
ContractService->>ChatService: AiMessageBtn: 다음 단계 안내
ContractService-->>ContractController: DTO
ContractController-->>Client: DTO
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (10)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 관련 이슈
🔑 주요 변경사항
✔️ 체크 리스트
mainbranch에 실수로 PR 생성 금지)📢 To Reviewers
📸 스크린샷 or 실행영상
Summary by CodeRabbit