Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for latest Derive, SparseArraysBase #10

Merged
merged 14 commits into from
Dec 16, 2024
Merged

Update for latest Derive, SparseArraysBase #10

merged 14 commits into from
Dec 16, 2024

Conversation

mtfishman
Copy link
Member

@mtfishman mtfishman commented Dec 11, 2024

Supersedes #8. Depends on ITensor/SparseArraysBase.jl#3.

To-do:

  • Rewrite function definitions function blocksparse_f(...) [...] end to @interface ::AbstractBlockSpareArrayInterface function f(...) [...] end.
  • Remove NDTensors as test dependency. (Closes [ENHANCEMENT] Remove NDTensors as test dependency #12)
  • Get tests passing.
  • Rename block_storedlength to blockstoredlength.
  • Rename block_reshape to blockreshape.
  • Rename block_eachstoredindex to eachblockstoredindex.
  • Define eachstoredblock for iterating over stored blocks, analogous to BlockArrays.eachblock.
  • Add a test for ArrayLayouts.zero!, check that it empties the storage.

Copy link

codecov bot commented Dec 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@mtfishman mtfishman changed the title [WIP] Update for latest Derive, SparseArraysBase Update for latest Derive, SparseArraysBase Dec 16, 2024
@mtfishman mtfishman marked this pull request as ready for review December 16, 2024 03:59
@mtfishman mtfishman merged commit d1958cc into main Dec 16, 2024
11 checks passed
@mtfishman mtfishman deleted the derive2 branch December 16, 2024 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Remove NDTensors as test dependency
1 participant