Merge pull request #431 from emstoudenmire/issue_430_z3qn

Fix missing return statement in QNVal constructor
ITensor · Jun 17, 2020 · bcecd90 · bcecd90
2 parents 9b75c27 + 8aa749b
commit bcecd90
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/qn/qn.jl b/src/qn/qn.jl
@@ -7,7 +7,7 @@ struct QNVal
   function QNVal(name,v::Int,m::Int=1)
     am = abs(m)
     if am > 1
-      new(SmallString(name),mod(v,am),m)
+      return new(SmallString(name),mod(v,am),m)
     end
     new(SmallString(name),v,m)
   end
@@ -25,9 +25,9 @@ isfermionic(qv::QNVal) = modulus(qv) < 0
 Base.:<(qv1::QNVal,qv2::QNVal) = (name(qv1) < name(qv2))
 
 function qn_mod(val::Int,modulus::Int)
-  modulus = abs(modulus)
-  (modulus == 0 || modulus == 1) && return val
-  return mod(val,modulus)
+  amod = abs(modulus)
+  amod <= 1 && return val
+  return mod(val,amod)
 end
 
 function Base.:-(qv::QNVal)