-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 4th of July Event items #293
Conversation
Some items are missing textures. They'll be added as soon as I have them finished.
I am just bad at using separators 😄 |
There was a keypair error. Maybe this'll fix it.
Finally! Have fun! |
I had to put the rarity and sell_price the other way around, because it was a bit off. Thanks Maxi for spotting the problem 😄
the items have way too high sell values for their rarity, and imo you could have just used last year's 4th of july items instead of making new ones |
it also seems not all items are mine&fish, is this a bug? |
This is fixed right away. |
This is not a bug, just to make the items a bit more random. Some normal items can't be fished or mined too, as they're specific to one method. |
"lady_liberty_tabula_ansata": "<:air:828359049602662431>", | ||
"hot_dog": "<:hot_dog:1256238582985785470>", | ||
"4th_of_july_decorations": "<:air:828359049602662431>", | ||
"a_literal_bonfire": "<:air:828359049602662431>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For items with no emoji just don't add them here ig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a few should be removed:
- Eating Competition Prize
- A Literal Bonfire
- 4th Of July Decorations
- Lady Liberty Tabula Ansata
- Lady Liberty Torch
- Declaration Of Independence
- Freedom Firework Bundle
But I do like the rest, we could also maybe add:
- Komodo 30000 SuperNova Aerial Firework (with a bomb emoji)
@ZethalMC Since you opened this from your I'm going to close this PR and make a new one off your branch. |
Some items are missing textures. They'll be added as soon as I have them finished.