fix #1746: reuse contextual menu for all files #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
malykhinvi
commented
Jul 31, 2024
| @@ -227,22 +223,6 @@ export const mixin = { | |||
| type: 'is-success' | |||
| }) | |||
| }, | |||
| /** | |||
There was a problem hiding this comment.
I have removed filters and methods that are not used in the code
|
I've reviewed it and it's really a very good optimisation solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix IceWhaleTech/CasaOS#1746
The problem:
The
ActionButtoncomponent renders a dropdown for every file in the folder even though it is visible only after click. If there are many files in the folder, the browser might freeze.The solution:
ActionButtonso that it would be just a trigger forContextMenucomponentopenContextMenuwhen user clicksActionButtonResults:
Switching between grid view and list view.
50 txt files, macbook air m1