entrypoint: update to Icinga DB v1.2.0 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of <Icinga/icingadb#707>. As Icinga DB's go.mod `go` version got incremented, the same should be done here as well. Furthermore, the package "github.com/icinga/icingadb/pkg/driver" was moved to "github.com/icinga/icingadb/pkg/icingadb". To minimize the change, an aliased import was used. My editor took the liberty to reorder the imports.
julianbrost
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Attempting to reconnect works, however, when doing so, it will throw a stack trace at you - in contrast to the actual Icinga DB daemon in that situation. Not sure if there's a quick way to fix this, so maybe it has to stay that way for now. At least it's not caused by this PR but probably due to the entry point just using zap.NewDevelopment() as logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Icinga/icingadb#707.
As Icinga DB's go.mod
goversion got incremented, the same should be done here as well. Furthermore, the package"github.com/icinga/icingadb/pkg/driver" was moved to "github.com/icinga/icingadb/pkg/icingadb". To minimize the change, an aliased import was used. My editor took the liberty to reorder the imports.