Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query execution utilities #18

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions database/contracts.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
package database

import (
"context"
"github.com/jmoiron/sqlx"
)

// Entity is implemented by each type that works with the database package.
type Entity interface {
Fingerprinter
Expand Down Expand Up @@ -54,3 +59,10 @@ type PgsqlOnConflictConstrainter interface {
// PgsqlOnConflictConstraint returns the primary or unique key constraint name of the PostgreSQL table.
PgsqlOnConflictConstraint() string
}

// TxOrDB is just a helper interface that can represent a *[sqlx.Tx] or *[DB] instance.
yhabteab marked this conversation as resolved.
Show resolved Hide resolved
type TxOrDB interface {
sqlx.ExtContext

PrepareNamedContext(ctx context.Context, query string) (*sqlx.NamedStmt, error)
}
26 changes: 26 additions & 0 deletions database/db.go
Original file line number Diff line number Diff line change
Expand Up @@ -652,6 +652,26 @@ func (db *DB) Delete(
return db.DeleteStreamed(ctx, entityType, idsCh, onSuccess...)
}

// RunInTx allows running a function in a database transaction without requiring manual transaction handling.
//
// A new transaction is started on [DB] which is then passed to fn. After fn returns, the transaction is
// committed unless an error was returned. If fn returns an error, that error is returned or when failing
// to start or/and commit the transaction.
func (db *DB) RunInTx(ctx context.Context, fn func(tx *sqlx.Tx) error) error {
tx, err := db.BeginTxx(ctx, nil)
if err != nil {
return errors.Wrap(err, "DB.RunInTx: cannot start a database transaction")
}
// We don't expect meaningful errors from rolling back the tx other than the sql.ErrTxDone, so just ignore it.
defer func() { _ = tx.Rollback() }()

if err := fn(tx); err != nil {
return err
}

return errors.Wrap(tx.Commit(), "DB.RunInTx: cannot commit a database transaction")
}

func (db *DB) GetSemaphoreForTable(table string) *semaphore.Weighted {
db.tableSemaphoresMu.Lock()
defer db.tableSemaphoresMu.Unlock()
Expand Down Expand Up @@ -693,3 +713,9 @@ func (db *DB) Log(ctx context.Context, query string, counter *com.Counter) perio
db.logger.Debugf("Finished executing %q with %d rows in %s", query, counter.Total(), tick.Elapsed)
}))
}

var (
// Assert TxOrDB interface compliance of the DB and sqlx.Tx types.
_ TxOrDB = (*DB)(nil)
_ TxOrDB = (*sqlx.Tx)(nil)
)
42 changes: 42 additions & 0 deletions database/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"github.com/icinga/icinga-go-library/com"
"github.com/icinga/icinga-go-library/strcase"
"github.com/icinga/icinga-go-library/types"
"github.com/jmoiron/sqlx"
"github.com/pkg/errors"
)

Expand Down Expand Up @@ -43,6 +44,47 @@ func SplitOnDupId[T IDer]() com.BulkChunkSplitPolicy[T] {
}
}

// InsertObtainID executes the given query and fetches the last inserted ID.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... here due to how special it is.

//
// Using this method for database tables that don't define an auto-incrementing ID, or none at all,
// will not work. The only supported column that can be retrieved with this method is id.
// This function expects [TxOrDB] as an executor of the provided query, and is usually a *[sqlx.Tx] or *[DB] instance.
// Returns the retrieved ID on success and error on any database inserting/retrieving failure.
func InsertObtainID(ctx context.Context, conn TxOrDB, stmt string, arg any) (int64, error) {
var resultID int64
switch conn.DriverName() {
case PostgreSQL:
query := stmt + " RETURNING id"
ps, err := conn.PrepareNamedContext(ctx, query)
if err != nil {
return 0, errors.Wrapf(err, "cannot prepare %q", query)
}
// We're deferring the ps#Close invocation here just to be on the safe side, otherwise it's
yhabteab marked this conversation as resolved.
Show resolved Hide resolved
// closed manually later on and the error is handled gracefully (if any).
defer func() { _ = ps.Close() }()

if err := ps.GetContext(ctx, &resultID, arg); err != nil {
return 0, CantPerformQuery(err, query)
}

if err := ps.Close(); err != nil {
return 0, errors.Wrapf(err, "cannot close prepared statement %q", query)
}
default:
result, err := sqlx.NamedExecContext(ctx, conn, stmt, arg)
if err != nil {
return 0, CantPerformQuery(err, stmt)
}

resultID, err = result.LastInsertId()
if err != nil {
return 0, errors.Wrap(err, "cannot retrieve last inserted ID")
}
}

return resultID, nil
}

// setGaleraOpts sets the "wsrep_sync_wait" variable for each session ensures that causality checks are performed
// before execution and that each statement is executed on a fully synchronized node. Doing so prevents foreign key
// violation when inserting into dependent tables on different MariaDB/MySQL nodes. When using MySQL single nodes,
Expand Down