Allow matching config validation errors #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
force-pushed
the
allow-matching-config-validation-errors
branch
2 times, most recently
from
7e61437
to
ae4d57c
Compare
lippserd
force-pushed
the
allow-matching-config-validation-errors
branch
from
ae4d57c
to
5e07404
Compare
Any error returned from `Validate()` is propagated with `ErrInvalidConfiguration` attached, allowing `errors.Is()` checks on the returned errors to recognize both `ErrInvalidConfiguration` and the original errors returned from `Validate()`.
lippserd
force-pushed
the
allow-matching-config-validation-errors
branch
from
5e07404
to
d24577e
Compare
|
@oxzi you already approved #87, but I created this PR here first before changing the implementation over at Icinga/icingadb#831. |
oxzi
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any error returned from
Validate()is propagated withErrInvalidConfigurationattached, allowingerrors.Is()checks on the returned errors to recognize bothErrInvalidConfigurationand the original errors returned fromValidate().This will be utilized in Icinga DB to support loading configuration from both YAML files and environment variables. If loading from a YAML file fails, we will check for
ErrInvalidConfigurationto proceed with loading the configuration from environment variables, as it may be incomplete and will be revalidated inFromEnv().