Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Metric Sync #119

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Document Metric Sync #119

merged 2 commits into from
Sep 13, 2024

Conversation

Jan-Schuppik
Copy link
Collaborator

fix #117

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 4, 2024
@Jan-Schuppik Jan-Schuppik self-assigned this Sep 4, 2024
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the misunderstanding, but the idea behind the issue was to simply document the configuration options in 03-Configuration.md. It is not necessary to document how to set up Prometheus. But I think it makes sense to introduce 04-Features.md to briefly describe the metric sync and its purpose there.

@lippserd
Copy link
Member

@jhoxhaa Can you please take over here?

@lippserd
Copy link
Member

@Jan-Schuppik Thx for the commit :)

@lippserd lippserd added this to the 0.2.0 milestone Sep 11, 2024
@lippserd lippserd changed the title document the metric sync setup Document Metric Sync Sep 13, 2024
@lippserd lippserd merged commit 101a01e into main Sep 13, 2024
7 checks passed
@lippserd lippserd deleted the docs/add-metrics-sync branch September 13, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document Metric Sync and Configuration
3 participants