Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icinga states #126

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix icinga states #126

merged 2 commits into from
Sep 26, 2024

Conversation

jhoxhaa
Copy link
Collaborator

@jhoxhaa jhoxhaa commented Sep 13, 2024 •
edited by lippserd
Loading

This PR introduces the following changes:

  • Remove the grace period as it is unreliable. Each grace period would require a timer to clear the condition.
  • Treat replica set with 0 desired replicas as ok.

fixes Icinga/icinga-kubernetes-web#57
fixes Icinga/icinga-kubernetes-web#58
fixes Icinga/icinga-kubernetes-web#63

@jhoxhaa jhoxhaa self-assigned this Sep 13, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 13, 2024
@lippserd lippserd added this to the 0.2.0 milestone Sep 26, 2024
@lippserd lippserd merged commit 9ac5d7b into main Sep 26, 2024
7 checks passed
@lippserd lippserd deleted the fix-icinga-states branch September 26, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd Awaiting requested review from lippserd

Assignees

@jhoxhaa jhoxhaa

Labels
cla/signed CLA is signed by all contributors of a PR
Projects
None yet
Milestone
0.2.0
2 participants
@jhoxhaa @lippserd