Don't limit browser_session.user_agent to 4096 chars #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Al2Klimov
commented
Jul 22, 2024
Al2Klimov
commented
- This isn't necessary anymore due to Schema: don't limit browser_session.user_agent to 4096 chars icinga-notifications#239
IMHO that doesn't mean that this has to be removed. Having a reasonable limit still sounds like a good idea to me to prevent the database from filling up with too much garbage. Removing the hard-coded limit in the schema just means that Icinga Notifications Web is now able to more freely adjust that limit. |
|
Theoretically a UA could be 7.9KB, given that Apache 2 allows 8KB headers. |
nilmerg
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.