Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort config types by their load dependencies once #10148

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Sort config types by their load dependencies once #10148

merged 4 commits into from
Sep 26, 2024

Commits on Sep 20, 2024

  1. Introduce Type::GetConfigTypesSortedByLoadDependencies()

    @Al2Klimov @yhabteab
    Al2Klimov authored and yhabteab committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b848934 View commit details
    Browse the repository at this point in the history

  2. ConfigItem::CommitNewItems(): pre-sort types by their load dependenci… 

    …es once

to avoid complicated nested loops, iterating over the same types and
checking dependencies over and over, skipping already completed ones.
    @Al2Klimov @yhabteab
    Al2Klimov authored and yhabteab committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    31f3aca View commit details
    Browse the repository at this point in the history

  3. Type: Simplify sort by load dependencies algorithm

    @yhabteab
    yhabteab committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    467e8b1 View commit details
    Browse the repository at this point in the history

  4. Add basic test cases for `Type::GetConfigTypesSortedByLoadDependencie… 

    …s()`
    @yhabteab
    yhabteab committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    eb97676 View commit details
    Browse the repository at this point in the history