ApiListener: Log error context only once

[yhabteab]

When logging at the warning level, the logger will automatically look up for registered context and append them to the log entry accordingly.

icinga2/lib/base/logger.cpp

Lines 279 to 287 in 92399a9

	if (m_Severity >= LogWarning) {
	ContextTrace context;
	if (context.GetLength() > 0) {
	std::ostringstream trace;
	trace << context;
	entry.Message += "\nContext:" + trace.str();
	}
	}

Before

[2024-10-30 17:01:01 +0100] information/ApiListener: Sending replay log for endpoint 'satellite' in zone 'master'.
[2024-10-30 17:01:01 +0100] warning/JsonRpcConnection: API client disconnected for identity 'satellite'
[2024-10-30 17:01:01 +0100] warning/ApiListener: Error while replaying log for endpoint 'satellite': Error: Cannot send message to already disconnected API client 'satellite'!

Context:

        (0) Replaying log for Endpoint 'satellite'
Context:
        (0) Replaying log for Endpoint 'satellite'

[2024-10-30 17:01:01 +0100] warning/ApiListener: Removing API client for endpoint 'satellite'. 0 API clients left.

After

[2024-10-30 16:58:23 +0100] information/ApiListener: Sending replay log for endpoint 'satellite' in zone 'master'.
[2024-10-30 16:58:23 +0100] warning/JsonRpcConnection: API client disconnected for identity 'satellite'
[2024-10-30 16:58:23 +0100] warning/ApiListener: Removing API client for endpoint 'satellite'. 0 API clients left.
[2024-10-30 16:58:23 +0100] warning/ApiListener: Error while replaying log for endpoint 'satellite': Cannot send message to already disconnected API client 'satellite'!
Context:
        (0) Replaying log for Endpoint 'satellite'

[2024-10-30 16:58:23 +0100] information/ApiListener: Finished sending replay log for endpoint 'satellite' in zone 'master'.

[Al2Klimov]

Having is better than needing. ;-)

[yhabteab]

Why did you remove the backport label? This duplication originates from commit 932a534, which is backported to the 2.14 support branch.