Icinga DB feature: normalize several Redis data not to crash the Go daemon #9814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…,repeat_key} to boolean At the moment, the Icinga DB feature will use that value as-is and serialize it to JSON, resulting in a crash in Icinga DB down the road because it expects a boolean.
via `std::max(0, x)` not to crash the Go daemon which can't handle such.
…o number and, in case of null, fall back to Checkable#check_command.timeout, just like IcingaDB#SerializeState(). Otherwise the Go daemon crashes. It expects a number.
…edis not to crash the Go daemon which expects positive values there.
…o >=0 otherwise, e.g. with -42.5, the Go daemon crashes. It expects uints there.
…o crash Go daemon The latter expects ints, not floats - not to mention strings. Luckily Icinga already enforces numeric strings so that we can cast it to number.
….{begin,end} not to crash Go daemon
At least our PostgreSQL schema enforces positive values.
julianbrost
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Brings the support/2.13 branch up to date with master, i.e. git diff origin/2.13.8/icingadb..origin/master -- lib/icingadb/icingadb-objects.cpp only shows a few minor differences that don't have to be backported (code quality (remove redundant std::move) and writing original_attributes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of