IcingaDB#SendConfigDelete(): fix missing nullptr check before deref #9899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al2Klimov
added
the
consider backporting
icinga-probot
bot
added
area/icingadb
|
@Al2Klimov Were you able to reproduce the crash? My first attempt (schedule downtime, stop redis, cancel downtime) was of no success. |
|
No, but fortunately the issue OP's stack lead me to this obvious missing if. |
julianbrost
approved these changes
Nov 21, 2023
This was referenced Dec 20, 2023
Al2Klimov
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9897
Just as in the other methods of this kind.
Luckily the issue OP provided a stack trace.