Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: complain if PR adds commits from people not yet listed in ./AUTHORS #9911

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

Al2Klimov
Copy link
Member

not to have to update ./AUTHORS or .mailmap after merging.

This substitutes ProBot functionality.

@Al2Klimov Al2Klimov added enhancement New feature or request area/ci CI/CD labels Nov 20, 2023
@Al2Klimov Al2Klimov force-pushed the gha-AUTHORS branch 4 times, most recently from 74bbb03 to a8d4e9d Compare November 20, 2023 15:04
@Icinga Icinga deleted a comment from cla-bot bot Nov 20, 2023
@Icinga Icinga deleted a comment from cla-bot bot Nov 20, 2023
@Icinga Icinga deleted a comment from cla-bot bot Nov 20, 2023
@Icinga Icinga deleted a comment from cla-bot bot Nov 20, 2023
@Al2Klimov
Copy link
Member Author

Not critically necessary, but should prevent stuff like #9697 (comment).

@Al2Klimov Al2Klimov added this to the 2.15.0 milestone Nov 20, 2023
@Al2Klimov Al2Klimov added the consider backporting Should be considered for inclusion in a bugfix release label Nov 20, 2023
@Icinga Icinga deleted a comment from cla-bot bot Nov 20, 2023
.github/workflows/authors-file.yml Outdated Show resolved Hide resolved
not to have to update ./AUTHORS or .mailmap after merging.
Copy link

cla-bot bot commented Nov 21, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Lol cat.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@Icinga Icinga deleted a comment from cla-bot bot Nov 21, 2023
Copy link
Contributor

@julianbrost julianbrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine in the failing case, please remove the second commit so that we can also see it working if everything is fine.

@Al2Klimov Al2Klimov merged commit 2d167cc into master Nov 23, 2023
26 checks passed
@Al2Klimov Al2Klimov deleted the gha-AUTHORS branch November 23, 2023 11:38
@Al2Klimov Al2Klimov mentioned this pull request Nov 24, 2023
1 task
@Al2Klimov Al2Klimov mentioned this pull request Nov 24, 2023
@Al2Klimov Al2Klimov added backported Fix was included in a bugfix release and removed consider backporting Should be considered for inclusion in a bugfix release labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI/CD backported Fix was included in a bugfix release cla/signed enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants