Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate the number of affected children by a particular parent #1062

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Indicate the number of affected children by a particular parent #1062

merged 1 commit into from
Oct 7, 2024

Conversation

raviks789
Copy link
Contributor

@raviks789 raviks789 commented Sep 24, 2024 •
edited
Loading

ref #1058

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Sep 24, 2024
@raviks789 raviks789 changed the title WIP Indicate the number of affected children by a particular parent Sep 24, 2024
@raviks789 raviks789 force-pushed the dependency/affected-children branch 3 times, most recently from 766f5a0 to b7844fe Compare September 24, 2024 14:04
@nilmerg nilmerg added enhancement New feature or improvement area/representation Affects the representation of information labels Sep 30, 2024
@raviks789 raviks789 force-pushed the dependency/affected-children branch 2 times, most recently from e4b6781 to 2bd14ca Compare October 1, 2024 13:02
@raviks789 raviks789 force-pushed the dependency/affected-children branch 2 times, most recently from a0f6af0 to 2c5edaf Compare October 2, 2024 09:48
@raviks789 raviks789 changed the base branch from root-problem-list to dependencies October 2, 2024 09:48
@raviks789 raviks789 marked this pull request as ready for review October 2, 2024 09:48
@raviks789 raviks789 requested a review from nilmerg October 2, 2024 09:48
@raviks789 raviks789 force-pushed the dependency/affected-children branch 2 times, most recently from 93a1763 to c4c56d9 Compare October 2, 2024 10:06
nilmerg
nilmerg requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The background color of the indicator should always be red
  • The foreground color of the indicator must be light, as in the mockup

library/Icingadb/Widget/ItemList/StateListItem.php Outdated Show resolved Hide resolved
library/Icingadb/Widget/ItemList/StateListItem.php Outdated Show resolved Hide resolved
public/css/common.less Outdated Show resolved Hide resolved
public/css/common.less Outdated Show resolved Hide resolved
@raviks789 raviks789 requested a review from nilmerg October 2, 2024 11:06
nilmerg
nilmerg requested changes Oct 2, 2024
View reviewed changes
library/Icingadb/Widget/ItemList/StateListItem.php Outdated Show resolved Hide resolved
public/css/common.less Show resolved Hide resolved
@raviks789 raviks789 requested a review from nilmerg October 2, 2024 11:37
nilmerg
nilmerg approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@nilmerg nilmerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Though, please split this into two PR's one of which includes what we want to merge and the other the adjustments for the fake data. Just in case we need such again for further tests without having the real data.

@raviks789 raviks789 mentioned this pull request Oct 4, 2024
Draft
@nilmerg nilmerg linked an issue Oct 7, 2024 that may be closed by this pull request
Indicate the number of affected children by a particular parent #1058
Closed
nilmerg
nilmerg requested changes Oct 7, 2024
View reviewed changes
library/Icingadb/Model/Host.php Outdated Show resolved Hide resolved
library/Icingadb/Model/Service.php Outdated Show resolved Hide resolved
library/Icingadb/Model/State.php Outdated Show resolved Hide resolved
public/css/common.less Outdated Show resolved Hide resolved
library/Icingadb/Common/IcingaRedis.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the dependency/affected-children branch 2 times, most recently from 689739f to 847c00d Compare October 7, 2024 08:10
@raviks789 raviks789 requested a review from nilmerg October 7, 2024 08:31
@nilmerg nilmerg merged commit b8498c7 into dependencies Oct 7, 2024
1 check passed
@nilmerg nilmerg deleted the dependency/affected-children branch October 7, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilmerg nilmerg nilmerg approved these changes

Assignees

@raviks789 raviks789

Labels
area/representation Affects the representation of information cla/signed CLA is signed by all contributors of a PR enhancement New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Indicate the number of affected children by a particular parent
2 participants
@raviks789 @nilmerg