Skip to content

Conversation

@BastianLedererIcinga
Copy link
Contributor

Changes that had to be addressed

PHP 8.3 -> Php 8.4

Migration docs: https://www.php.net/manual/en/migration84

  • Function parameters that are null by default must be declared nullable.

PHP 8.4 -> PHP 8.5

Migration Docs: https://www.php.net/manual/en/migration85

  • Driver specific PDO constants are deprecated this affects some MySQL driver constants,
    instead of PDO::SQL<constant_name> use Pdo\Mysql::<constant_name>.
  • ReflectionProperty::setAccessible has been deprecated, but did not have any effect since PHP 8.1.
  • Passing null as $key parameter to array_key_exists() is deprecated

resolves: #1312

@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Dec 3, 2025
@BastianLedererIcinga BastianLedererIcinga self-assigned this Dec 3, 2025
sukhwinder33445
sukhwinder33445 previously approved these changes Dec 5, 2025
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, @Jan-Schuppik, please approve it when the UI tests are also fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHP 8.4/8.5 Support

3 participants