-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: Docker: don't run on support/* branches #758
base: main
Are you sure you want to change the base?
Conversation
PRs to them are already covered and we don't need support* image tags.
So the main goal of this PR to not push them to Docker Hub anymore?
Partially. We don't require that PRs are rebased on the latest version on the target branch, so there's a small chance that merging an older PR results in an issue on the target branch. |
👍
The chance that such issue occurs only in the Docker GHA is even smaller. |
That sounds more like a workaround for limitations in Though that raises the question whether we want to fix something in |
|
To be honest, I don't quite understand your discussion as images are really not needed for support branches and a similar PR has already been merged in Icinga 2. But I welcome moving the Dockerfile here, which still requires environment variable support to be merged, but that is something that is definitely coming. @Al2Klimov please answer #758 (comment). I'm also wondering about the "we don't need support* image tags" wording. These branches are supposed to have tags for which an image should be built and published. But I think you mean that we tag the image with the name of the support branch? In that case, I would just write "images for support branches". Anyway, please clarify. @julianbrost any objections to just merging? |
Not really. You'd probably have to try very hard to introduce a problem that was only caught by that single job. Still, I find it strange that we have to remove the whole job just to prevent the upload. I'd just find it much nicer if every single commit would run the same set of checks before and after merging, avoiding the whole "is this job strictly necessary in this situation" consideration. |
Sorry to ask again 😆, but I think I have understood the point: You still want to create the image, but just not push it, right? If so, I second that, but I would like to cover this when moving the Dockerfile here. |
Yes, exactly. For all the other jobs we don't ask the question "do we need the build artifacts for anything afterwards" either. And my intuition says that adding a simple |
Exactly my opinion.
Exactly what I meant. This PR is just about for which branches that GHA runs and pushes images named after the respective branch. It has nothing to do with tags.
Well, then... |
If we break it intentionally this way, we deserve it. :-) |
PRs to them are already covered and we don't need support* image tags.