Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScheduleForm: Add Send Report Now button #137

Merged
merged 1 commit into from
Mar 15, 2023
Merged

ScheduleForm: Add Send Report Now button #137

merged 1 commit into from
Mar 15, 2023

Conversation

jhoxhaa
Copy link
Contributor

@jhoxhaa jhoxhaa commented Aug 2, 2022 •
edited
Loading

resolves #133

@cla-bot cla-bot bot added the cla/signed label Aug 2, 2022
@jhoxhaa jhoxhaa requested a review from lippserd August 2, 2022 14:35
@jhoxhaa jhoxhaa self-assigned this Aug 2, 2022
@jhoxhaa jhoxhaa force-pushed the feature/add-send-now-button-to-schedule-form-133 branch 2 times, most recently from 10da1a9 to 0e0b6a6 Compare August 2, 2022 14:43
@jhoxhaa jhoxhaa force-pushed the feature/add-send-now-button-to-schedule-form-133 branch from 0e0b6a6 to c1024af Compare September 5, 2022 11:01
@lippserd lippserd requested a review from yhabteab November 28, 2022 14:27
yhabteab
yhabteab requested changes Nov 28, 2022
View reviewed changes
Copy link
Member

@yhabteab yhabteab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see send report now button here :)

Bildschirm­foto 2022-11-28 um 17 16 13

@yhabteab
Copy link
Member

Can't see send report now button here :)

My bad! This is not the right form! 🙈

@jhoxhaa jhoxhaa force-pushed the feature/add-send-now-button-to-schedule-form-133 branch from c1024af to aa5436b Compare November 29, 2022 10:15
@yhabteab
Copy link
Member

Blocked by

@yhabteab yhabteab added the enhancement New feature or request label Jan 26, 2023
@jhoxhaa jhoxhaa force-pushed the feature/add-send-now-button-to-schedule-form-133 branch from aa5436b to 17a123f Compare March 14, 2023 15:37
@jhoxhaa jhoxhaa requested a review from yhabteab March 14, 2023 15:39
@jhoxhaa jhoxhaa force-pushed the feature/add-send-now-button-to-schedule-form-133 branch from 17a123f to eba5f4d Compare March 14, 2023 16:24
yhabteab
yhabteab requested changes Mar 15, 2023
View reviewed changes
library/Reporting/Web/Forms/ScheduleForm.php Outdated Show resolved Hide resolved
library/Reporting/Web/Forms/ScheduleForm.php Outdated Show resolved Hide resolved
@jhoxhaa jhoxhaa force-pushed the feature/add-send-now-button-to-schedule-form-133 branch from eba5f4d to e6a22d0 Compare March 15, 2023 11:49
@jhoxhaa jhoxhaa force-pushed the feature/add-send-now-button-to-schedule-form-133 branch from e6a22d0 to d016784 Compare March 15, 2023 12:41
@jhoxhaa jhoxhaa requested a review from yhabteab March 15, 2023 12:43
@jhoxhaa jhoxhaa force-pushed the feature/add-send-now-button-to-schedule-form-133 branch 3 times, most recently from 79af43a to 99d479e Compare March 15, 2023 15:11
@yhabteab yhabteab requested review from lippserd and removed request for lippserd March 15, 2023 15:13
@yhabteab
Copy link
Member

@lippserd Do you want to have a look?

lippserd
lippserd reviewed Mar 15, 2023
View reviewed changes
library/Reporting/Web/Forms/ScheduleForm.php Outdated
$action = new $values['action']();
$action->execute($this->report, $values);

Notification::success(t('Report sent successfully'));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace t() with $this->translate(). After that it's free to merge.

@yhabteab yhabteab added this to the 1.0.0 milestone Mar 15, 2023
@jhoxhaa jhoxhaa force-pushed the feature/add-send-now-button-to-schedule-form-133 branch from 99d479e to e4dc85e Compare March 15, 2023 15:49
@jhoxhaa jhoxhaa requested review from lippserd and yhabteab March 15, 2023 15:53
@yhabteab yhabteab merged commit 3fc93d3 into master Mar 15, 2023
@yhabteab yhabteab deleted the feature/add-send-now-button-to-schedule-form-133 branch March 15, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lippserd lippserd lippserd approved these changes

@yhabteab yhabteab yhabteab approved these changes

Assignees

@jhoxhaa jhoxhaa

Labels
cla/signed enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

"Send Report now" button under Schedule
3 participants
@jhoxhaa @yhabteab @lippserd