Github Actions: Add Phpstan

.github/workflows/php.yml

@@ -32,6 +32,8 @@ jobs:
 
       - name: Setup dependencies
         run: composer require -n --no-progress overtrue/phplint
+          && git clone --single-branch --branch snapshot/nightly https://github.com/Icinga/icinga-php-library.git vendor/icinga-php-library
+          && git clone --single-branch --branch snapshot/nightly https://github.com/Icinga/icinga-php-thirdparty.git vendor/icinga-php-thirdparty
 
       - name: PHP Lint
         if: success() || matrix.allow_failure
@@ -41,6 +43,10 @@ jobs:
         if: success() || matrix.allow_failure
         run: phpcs -wps --colors
 
+      - name: PHPStan
+        uses: php-actions/phpstan@v3
+        if: success() || matrix.allow_failure
+
   test:
     name: Unit tests with php ${{ matrix.php }} on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}

phpstan.neon

@@ -0,0 +1,11 @@
+parameters:
+    level: max
+
+    checkMissingIterableValueType: false
+    checkGenericClassInNonGenericObjectType: false
+
+    paths:
+        - src
+
+    scanDirectories:
+        - vendor

src/X509CertValidator.php

@@ -11,6 +11,10 @@ class X509CertValidator extends BaseValidator
 {
     use Translation;
 
+    /**
+     * @param String $value
+     * @return bool
+     */
     public function isValid($value)
     {
         // Multiple isValid() calls must not stack validation messages