Merge pull request #5 from PascalDR/fix/random_crash

Fix random crash for missing y coordinate
IdentityPython · Feb 9, 2024 · 9fe32bb · 9fe32bb
2 parents 7983fdb + 8ad32e6
commit 9fe32bb
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/pymdoccbor/mso/verifier.py b/pymdoccbor/mso/verifier.py
@@ -2,7 +2,7 @@
 import cryptography
 import logging
 
-from pycose.keys import CoseKey, EC2Key
+from pycose.keys import EC2Key
 from pycose.messages import Sign1Message
 
 from pymdoccbor.exceptions import (
@@ -52,7 +52,7 @@ def __init__(self, data: cbor2.CBORTag) -> None:
                 f"MsoParser only supports raw bytes and list, a {type(data)} was provided"
             )
 
-        self.object.key: CoseKey | None = None
+        self.object.key = None
         self.public_key: cryptography.hazmat.backends.openssl.ec._EllipticCurvePublicKey = None
         self.x509_certificates: list = []
 
@@ -130,9 +130,8 @@ def load_public_key(self) -> None:
 
         key = EC2Key(
             crv=settings.COSEKEY_HAZMAT_CRV_MAP[self.public_key.curve.name],
-            x=self.public_key.public_numbers().x.to_bytes(
-                settings.CRV_LEN_MAP[self.public_key.curve.name], 'big'
-            )
+            x=self.public_key.public_numbers().x.to_bytes(settings.CRV_LEN_MAP[self.public_key.curve.name], 'big'),
+            y=self.public_key.public_numbers().y.to_bytes(settings.CRV_LEN_MAP[self.public_key.curve.name], 'big')
         )
         self.object.key = key