Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/tests] Unit tests #2

Merged
merged 21 commits into from
Feb 8, 2024
Merged

Conversation

PascalDR
Copy link
Contributor

@PascalDR PascalDR commented Jan 31, 2024

This PR try to resolve issue 1, adds docstring, apply some refactoring and adds some feature.

Crash on verify methods (31/01/2024):
At the actual state two tests crash randomically (test_mobile_document_verify, test_mso_verifier_verify_signatures).
To try to fix this issue the i've changed the generation of JWK using EC2Key's generate_key method but the crashes continues to persist.

@peppelinux
Copy link
Member

@PascalDR unit tests fails due to py39, please move to py3.10

@PascalDR PascalDR marked this pull request as ready for review February 5, 2024 11:31
@PascalDR PascalDR changed the title [WIP][Feat/tests] Unit tests [Feat/tests] Unit tests Feb 5, 2024
@peppelinux peppelinux mentioned this pull request Feb 8, 2024
@peppelinux peppelinux merged commit c57434f into IdentityPython:main Feb 8, 2024
2 checks passed
@peppelinux peppelinux mentioned this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants