Remove restrictive cbor2 pin #25
Conversation
(cherry picked from commit 5f56c5d)
| cert_path: str | None = None, | ||
| revocation: dict | None = None, | ||
| status: dict | None = None | ||
| status: dict | None = None, |
There was a problem hiding this comment.
| status: dict | None = None, | |
| status: dict | None = None |
| encoding=serialization.Encoding.Raw, | ||
| format=serialization.PublicFormat.Raw | ||
| ) | ||
| format=serialization.PublicFormat.Raw, |
There was a problem hiding this comment.
| format=serialization.PublicFormat.Raw, | |
| format=serialization.PublicFormat.Raw |
| "big" | ||
| ) | ||
| (public_key.public_numbers().e.bit_length() + 7) // 8, "big" | ||
| ), |
| validity=validity, | ||
| revocation=revocation, | ||
| cert_info=self.cert_info | ||
| cert_info=self.cert_info, |
There was a problem hiding this comment.
| cert_info=self.cert_info, | |
| cert_info=self.cert_info |
| validity=validity, | ||
| revocation=revocation, | ||
| cert_info=self.cert_info | ||
| cert_info=self.cert_info, |
There was a problem hiding this comment.
| cert_info=self.cert_info, | |
| cert_info=self.cert_info |
| mso = msoi.sign( | ||
| doctype=doctype, | ||
| device_key=devicekeyinfo, | ||
| valid_from=datetime.now(timezone.utc), |
There was a problem hiding this comment.
| valid_from=datetime.now(timezone.utc), | |
| valid_from=datetime.now(timezone.utc) |
| for ns, dgst in msoi.disclosure_map.items() | ||
| }, | ||
| "issuerAuth": cbor2.decoder.loads(mso_cbor), | ||
| "issuerAuth": cbor2.loads(mso_cbor), |
There was a problem hiding this comment.
| "issuerAuth": cbor2.loads(mso_cbor), | |
| "issuerAuth": cbor2.loads(mso_cbor) |
|
we may have security updates in 5.4.x and breaking changes in 5.5.0, this is why we decided to specify the version of a dependency using a known minor release
therefore we should move our deps up to cbor2 55., and removing support for 5.4 we wil lcontinue the review, I am interested in having in this current PR also these ones:
I'd wait for any of your proposal for the impl of the previous tasks, therefore I will engage @PascalDR in the final review |
This merge request:
cbor2>=5.4.0,<5.5.0, which can cause dependency‑resolution conflicts and block downstream projects from receiving security updates.cbor2to the latest release. This surfaced a change in date/time handling that affectspyMDOC-CBOR.Impact:
pymdoccbor/tests/test_08_mdoc_cbor.py.Next steps: