Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add secp384r1 mapping #6

Merged
merged 4 commits into from
Apr 11, 2024
Merged

add secp384r1 mapping #6

merged 4 commits into from
Apr 11, 2024

Conversation

PatStLouis
Copy link
Contributor

I'm leveraging this library to evaluate deviceResponse objects from third party vendors. This was a required addition, could I get a review on this?

@PatStLouis
add secp384r1 mapping
34524ec 
Signed-off-by: Patrick St-Louis <patrick.st-louis@idlab.org>
PascalDR
PascalDR reviewed Mar 26, 2024
View reviewed changes
pymdoccbor/settings.py Outdated Show resolved Hide resolved
PascalDR
PascalDR requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@PascalDR PascalDR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is better if we add secp521 too to support all cases of nist curves implemented in pycose.

For reference: curves.py

@peppelinux peppelinux self-requested a review March 28, 2024 13:04
PatStLouis
PatStLouis commented Apr 10, 2024
View reviewed changes
Copy link
Contributor Author

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

PatStLouis and others added 2 commits April 10, 2024 13:27
@PatStLouis @PascalDR
Update pymdoccbor/settings.py
2843611 
Co-authored-by: Pasquale De Rose <akira.zeta@gmail.com>
@PatStLouis @PascalDR
Update pymdoccbor/settings.py
e1e3965 
Co-authored-by: Pasquale De Rose <akira.zeta@gmail.com>
@PatStLouis
Copy link
Contributor Author

@PascalDR I committed the change request, are we good to request a merge?

peppelinux
peppelinux reviewed Apr 10, 2024
View reviewed changes
pymdoccbor/settings.py
"secp256r1": "P_256"
"secp256r1": "P_256",
"secp384r1": "P_384",
"secp521r1": "P_521"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"secp521r1": "P_521"
"secp521r1": "P_521"

@peppelinux
Copy link
Member

@PatStLouis could I ask you to set 0.7.0 here?
https://github.com/IdentityPython/pyMDOC-CBOR/blob/main/pymdoccbor/__init__.py
this would allow us to create a new release

@PatStLouis
Copy link
Contributor Author

@peppelinux done!

@peppelinux peppelinux merged commit 4d5bdee into IdentityPython:main Apr 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peppelinux peppelinux peppelinux approved these changes

@PascalDR PascalDR Awaiting requested review from PascalDR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatStLouis @peppelinux @PascalDR