Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace validateMove with getValidMoves #135

Closed
Ido-Barnea opened this issue Jan 9, 2024 · 0 comments · Fixed by #137
Closed

Replace validateMove with getValidMoves #135

Ido-Barnea opened this issue Jan 9, 2024 · 0 comments · Fixed by #137
Assignees
@Ido-Barnea
Labels
infra Changes and improvements to the project's infrastructure

Comments

@Ido-Barnea
Copy link
Owner

Instead of getting a target position and returning a position (whatvalidateMove does), we should create a function getValidMoves which returns all the valid moves a piece has. It should make the code more readable and help with implementing #45.
@Ido-Barnea Ido-Barnea added the infra Changes and improvements to the project's infrastructure label Jan 9, 2024
@Ido-Barnea Ido-Barnea self-assigned this Jan 9, 2024
Ido-Barnea added a commit that referenced this issue Jan 12, 2024
@Ido-Barnea
[#135] Redesigned piece movement validation logic
738a538
Ido-Barnea added a commit that referenced this issue Jan 12, 2024
@Ido-Barnea
[#135] Minor fixes
a42dac3
@Ido-Barnea Ido-Barnea linked a pull request Jan 12, 2024 that will close this issue
Redesigned piece movement validation logic #137
Merged
Ido-Barnea added a commit that referenced this issue Jan 12, 2024
@Ido-Barnea
[#135] Minor fixes to tests
d4e162d
Ido-Barnea added a commit that referenced this issue Jan 13, 2024
@Ido-Barnea
[#135] Fixed enPassant movement
078eab2
Ido-Barnea added a commit that referenced this issue Jan 13, 2024
@Ido-Barnea
[#135] Fixed tests
cb6c303
Ido-Barnea added a commit that referenced this issue Jan 13, 2024
@Ido-Barnea
[#135] Fixed item interaction logic
ada2b83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ido-Barnea Ido-Barnea

Labels
infra Changes and improvements to the project's infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redesigned piece movement validation logic Ido-Barnea/Chess-But-Better
1 participant
@Ido-Barnea